Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] docs update #3103

Merged
merged 12 commits into from
Apr 20, 2021
Merged

[local_auth] docs update #3103

merged 12 commits into from
Apr 20, 2021

Conversation

snwagbata
Copy link
Contributor

@snwagbata snwagbata commented Oct 1, 2020 •
edited
Loading

The message that shows up is "This app was designed to support Touch ID. It has not been updated for Face ID." not "touch id"

Description

The wrong error message is mentioned in the docs. This fixes that.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@snwagbata
Update README.md
bf4d95d 
The message that shows up is "This app was designed to support Touch ID. It has not been updated for Face ID." not "touch id"
stuartmorgan-g
stuartmorgan-g suggested changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This will also need a version update in pubspec.yaml and CHANGELOG.md so that we can publish it, since the published version of the README is what most people see.

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

@snwagbata
Copy link
Contributor Author

Hi @stuartmorgan, since the version of local_auth has changed since this PR, do I copy those changes into my branch and commit it

@stuartmorgan-g
Copy link
Contributor

You would merge master into your branch.

@snwagbata snwagbata requested a review from stuartmorgan-g April 8, 2021 19:21
@snwagbata
Copy link
Contributor Author

@stuartmorgan I've merged master into my branch and updated the changelog

@cyanglaz
Copy link
Contributor

@snwagbata Looks like there's still some conflicts between master and this PR :)

@snwagbata
Copy link
Contributor Author

@cyanglaz it seems someone made an update to the CHANGELOG sometime in the past few days, I just resolved that conflict.

cyanglaz
cyanglaz previously requested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 1.1.4 has already been released, we would require a new release for this. so 1.1.5

@snwagbata snwagbata requested a review from cyanglaz April 16, 2021 13:40
@snwagbata
Copy link
Contributor Author

@cyanglaz hi, I just updated the CHNAGELOG and pubspec for the new release

stuartmorgan-g
stuartmorgan-g approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 19, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • This pull request has changes requested by @cyanglaz. Please resolve those before re-applying the label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 19, 2021
@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 20, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • This pull request has changes requested by @cyanglaz. Please resolve those before re-applying the label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 20, 2021
@stuartmorgan-g stuartmorgan-g merged commit ecf54b9 into flutter:master Apr 20, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 20, 2021
@engine-flutter-autoroll
ecf54b9 [local_auth] docs update (flutter/plugins#3103)
2870f8b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 20, 2021
@engine-flutter-autoroll
ecf54b9 [local_auth] docs update (flutter/plugins#3103)
9f9ee96
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 20, 2021
@engine-flutter-autoroll
ecf54b9 [local_auth] docs update (flutter/plugins#3103)
952fa3f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2021
@engine-flutter-autoroll
ecf54b9 [local_auth] docs update (flutter/plugins#3103)
452b3c7
bhaveshptl pushed a commit to bhaveshptl/plugins that referenced this pull request Apr 23, 2021
@bhaveshhzt
Merge branch 'master' into webview_file_picker
72e55e2 
* master: (397 commits)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  Path provider windows crash fix (flutter#3814)
  [local_auth] docs update (flutter#3103)
  Update PULL_REQUEST_TEMPLATE.md (flutter#3801)
  [quick_actions] handle cold start on iOS correctly (flutter#3811)
  Replace path_provider_linux widget tests with simple unit tests (flutter#3812)
  [sensors] format dart code based on the new dart formatter (flutter#3809)
  [google_sign_in] Fix "pick account" on iOS (flutter#3805)
  [image_picker_platform_interface] Added pickMultiImage (flutter#3782)
  [in_app_purchase] Added currency code and numerical price to product detail model. (flutter#3794)
  [local_auth] Fix iOS crash when no localizedReason (flutter#3780)
  Fix and update version checks (flutter#3792)
  [in_app_purchase] Configured example app to use StoreKit Testing on iOS 14 (flutter#3772)
  [local_auth] Unnecessary reassignment in example removed (flutter#2983)
  [flutter_webview] Fix `allowsInlineMediaPlayback` ignored on iOS (flutter#3791)
  Switch script/tools over to the new analysis options (flutter#3777)
  ...
yasargil added a commit to yasargil/plugins that referenced this pull request Apr 28, 2021
@yasargil
Merge branch 'master' into gmain
58ff4c0 
* master: (79 commits)
  Fix grammatical error in contributing guide (flutter#3217)
  [google_sign_in_web] fix README typos.
  [tool] combine run and runAndExitOnError (flutter#3827)
  [camera] android-rework part 2: Android auto focus feature (flutter#3796)
  [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826)
  Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822)
  [path_provider_*] code cleanup: sort directives (flutter#3823)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  Path provider windows crash fix (flutter#3814)
  [local_auth] docs update (flutter#3103)
  Update PULL_REQUEST_TEMPLATE.md (flutter#3801)
  [quick_actions] handle cold start on iOS correctly (flutter#3811)
  Replace path_provider_linux widget tests with simple unit tests (flutter#3812)
  [sensors] format dart code based on the new dart formatter (flutter#3809)
  [google_sign_in] Fix "pick account" on iOS (flutter#3805)
  [image_picker_platform_interface] Added pickMultiImage (flutter#3782)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@snwagbata @fotiDim
[local_auth] docs update (flutter#3103)
6c2ba0c 
Fixes incorrect reference to Touch ID rather than Face ID
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes p: local_auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snwagbata @stuartmorgan-g @cyanglaz @fluttergithubbot @googlebot