Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Migrates the url_launcher_web package to null safety #3171

Closed

Conversation

mvanbeusekom
Copy link
Contributor

Description

This pull request add null safety support to the url_launcher_web package.

This PR is currently in "draft" since several dependencies of the test project don't support null safety yet which results in to failing integration tests. As discussed with @ditman and @blasten we decided to leave the PR in draft until the packages the url_launcher_web depends on are also migrated (see also #3148 for the discussion).

The implementation depends on companion PR #3148 which add null safety support to the url_launcher package. Since PR #3148 isn't merged as of yet the dependency is currently based on a path reference, which should be fixed before merging this PR.

Related Issues

flutter/flutter#66395

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@ditman ditman self-assigned this Oct 22, 2020
@creativecreatorormaybenot
Copy link
Contributor

Resolves flutter/flutter#72239.

@blasten
Copy link

blasten commented Dec 15, 2020

The nnbd branch has been merged into master. Feel free to reopen this PR and reassign it to me. Thanks!

@blasten blasten closed this Dec 15, 2020
@mvanbeusekom mvanbeusekom deleted the url_launcher_web_null_safety branch September 21, 2021 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants