This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[connectivity][connectvity_platform_interface] migrate to nnbd #3176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 20, 2020 13:11
added 3 commits
October 20, 2020 19:22
blasten
reviewed
Oct 22, 2020
| @@ -23,12 +23,12 @@ class Connectivity { | |||
| if (_singleton == null) { | |||
| _singleton = Connectivity._(); | |||
| } | |||
| return _singleton; | |||
| return _singleton!; | |||
There was a problem hiding this comment.
Interesting. In some cases the analyzer is smart enough to figure out that _singleton cannot be null at this point, so ! isn't required.
There was a problem hiding this comment.
Got an error trying to remove !
./lib/connectivity.dart:25:12: Error: A value of type 'Connectivity?' can't be returned from a function with return type 'Connectivity'.
- 'Connectivity' is from 'package:connectivity/connectivity.dart' ('../lib/connectivity.dart').
return _singleton;```
blasten
reviewed
Oct 22, 2020
| @@ -1,3 +1,7 @@ | |||
| ## 1.1.0-nullsafety | |||
There was a problem hiding this comment.
I saw that other platform_interfaces are only bumping minor version. Are we going to break platform_interface as well?
blasten
reviewed
Oct 22, 2020
| @@ -14,7 +14,7 @@ ConnectivityResult parseConnectivityResult(String state) { | |||
| } | |||
|
|
|||
| /// Convert a String to a LocationAuthorizationStatus value. | |||
| LocationAuthorizationStatus parseLocationAuthorizationStatus(String result) { | |||
| LocationAuthorizationStatus parseLocationAuthorizationStatus(String? result) { | |||
There was a problem hiding this comment.
looks like result could be non-null, right?
blasten
reviewed
Oct 22, 2020
| @@ -1,7 +1,7 @@ | |||
| import 'package:connectivity_platform_interface/connectivity_platform_interface.dart'; | |||
|
|
|||
| /// Convert a String to a ConnectivityResult value. | |||
| ConnectivityResult parseConnectivityResult(String state) { | |||
| ConnectivityResult parseConnectivityResult(String? state) { | |||
There was a problem hiding this comment.
looks like state could be non-null, right?
added 3 commits
October 23, 2020 11:58
cyanglaz
commented
Oct 23, 2020
| @@ -1,3 +1,7 @@ | |||
| ## 1.1.0-nullsafety | |||
There was a problem hiding this comment.
I saw that other platform_interfaces are only bumping minor version. Are we going to break platform_interface as well?
| @@ -1,7 +1,7 @@ | |||
| import 'package:connectivity_platform_interface/connectivity_platform_interface.dart'; | |||
|
|
|||
| /// Convert a String to a ConnectivityResult value. | |||
| ConnectivityResult parseConnectivityResult(String state) { | |||
| ConnectivityResult parseConnectivityResult(String? state) { | |||
| @@ -14,7 +14,7 @@ ConnectivityResult parseConnectivityResult(String state) { | |||
| } | |||
|
|
|||
| /// Convert a String to a LocationAuthorizationStatus value. | |||
| LocationAuthorizationStatus parseLocationAuthorizationStatus(String result) { | |||
| LocationAuthorizationStatus parseLocationAuthorizationStatus(String? result) { | |||
| @@ -23,12 +23,12 @@ class Connectivity { | |||
| if (_singleton == null) { | |||
| _singleton = Connectivity._(); | |||
| } | |||
| return _singleton; | |||
| return _singleton!; | |||
There was a problem hiding this comment.
Got an error trying to remove !
./lib/connectivity.dart:25:12: Error: A value of type 'Connectivity?' can't be returned from a function with return type 'Connectivity'.
- 'Connectivity' is from 'package:connectivity/connectivity.dart' ('../lib/connectivity.dart').
return _singleton;```
added 3 commits
October 23, 2020 13:45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since connectivity_web has not migrated, temporarily un-endorse the web plugin.
All the deps are path deps for now, will submit another PR to update them to git dep after landing this.