Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Copy zoom settings from preview to final capture builder on Android #3413

Merged
merged 3 commits into from
Jan 14, 2021
Merged

[camera] Copy zoom settings from preview to final capture builder on Android #3413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4db01a6
Copy SCALER_CROP_REGION from preview to final capture builder
mvanbeusekom Jan 13, 2021
5e8ea8f
Update version number
mvanbeusekom Jan 13, 2021
5a37eab
Fix formatting
mvanbeusekom Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.7.0+4

* Make sure the configured zoom scale is copied over to the final capture builder on Android. Fixes the issue where the preview is zoomed but the final picture is not.

## 0.7.0+3

* Fixes crash with using inner camera on some Android devices.
Expand Down
4 changes: 4 additions & 0 deletions packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,11 +543,15 @@ private void runPictureCapture() {
final CaptureRequest.Builder captureBuilder =
cameraDevice.createCaptureRequest(CameraDevice.TEMPLATE_STILL_CAPTURE);
captureBuilder.addTarget(pictureImageReader.getSurface());
captureBuilder.set(
CaptureRequest.SCALER_CROP_REGION,
captureRequestBuilder.get(CaptureRequest.SCALER_CROP_REGION));
captureBuilder.set(
CaptureRequest.JPEG_ORIENTATION,
lockedCaptureOrientation == null
? deviceOrientationListener.getMediaOrientation()
: deviceOrientationListener.getMediaOrientation(lockedCaptureOrientation));

switch (flashMode) {
case off:
captureBuilder.set(CaptureRequest.CONTROL_AE_MODE, CaptureRequest.CONTROL_AE_MODE_ON);
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera
description: A Flutter plugin for getting information about and controlling the
camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
and streaming image buffers to dart.
version: 0.7.0+3
version: 0.7.0+4
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera

dependencies:
Expand Down