This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[image_picker] Migrate image_picker to package:cross_file #4073
Merged
ditman
merged 44 commits into
flutter:master
from
Baseflow:issue/70886-impl-android-ios
Jul 16, 2021
Merged
[image_picker] Migrate image_picker to package:cross_file #4073
ditman
merged 44 commits into
flutter:master
from
Baseflow:issue/70886-impl-android-ios
Jul 16, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
image_picker_for_web will need to be landed before the core plugin, so we can update the endorsed version and the platform_interface in one go. Can you split the changes to |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ditman It should now be ready to go! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…re. Leave new tests in a separate file.
…nd what to use instead.
ditman
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to go. I'm going to give a manual try to the example app in a couple of platforms (android, web) just to quickly verify.
(Looks good on Web and Android. Note that web has not implemented the "multi image picking" feature. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2021
Thanks @BeMacized!! |
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: image_picker
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all usages of PickedFile to XFile, to follow the changes made to the platform interface (#4072)
This PR will remain in draft state until the platform interface changes (#4072), as well as the web implementation of it (#4083) have been merged and published, so that the pubspec can be updated properly.
Relevant issue:
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.