Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Initialize SKError with correct data type #4113

Merged

Conversation

vladb99
Copy link
Contributor

@vladb99 vladb99 commented Jun 29, 2021

Makes sure that SKError.fromJson() gets the correct data type as argument.

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#85534

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g requested review from mvanbeusekom and renefloor and removed request for cyanglaz and LHLL July 1, 2021 20:11
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix I think the code looks good. The only thing missing is a unit-test that fails using the old code and works correctly with the new updated code.

This might mean that you will need to open up the SKPaymentQueueWrapper._handleObserverCallbacks(MethodCall) method and decorate it with the @visibleForTesting attribute. This would be fine, but make sure you also add the required method documentation. You can use the SKPaymentQueueWrapper. handlePaymentQueueDelegateCallbacks(MethodCall) method as example (example tests can be found in the sk_payment_queue_delegate_api_test.dart file).

@vladb99 vladb99 requested a review from mvanbeusekom July 2, 2021 10:52
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this contribution.

amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: in_app_purchase platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants