-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase] Initialize SKError with correct data type #4113
[in_app_purchase] Initialize SKError with correct data type #4113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix I think the code looks good. The only thing missing is a unit-test that fails using the old code and works correctly with the new updated code.
This might mean that you will need to open up the SKPaymentQueueWrapper._handleObserverCallbacks(MethodCall)
method and decorate it with the @visibleForTesting
attribute. This would be fine, but make sure you also add the required method documentation. You can use the SKPaymentQueueWrapper. handlePaymentQueueDelegateCallbacks(MethodCall)
method as example (example tests can be found in the sk_payment_queue_delegate_api_test.dart file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this contribution.
Makes sure that
SKError.fromJson()
gets the correct data type as argument.List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#85534
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).