This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_plugin_tools] Migrate firebase-test-lab to new base command #4116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Jun 30, 2021
| failingPackages.add(packageName); | ||
| continue; | ||
| } | ||
| int resultsCounter = 0; // Use a unique GCS bucket for each run. |
There was a problem hiding this comment.
It isn't clear how this comment relates to the proceeding code.
There was a problem hiding this comment.
Added more explanation.
| } | ||
| } | ||
| /// Finds and returns all integration test files for [package]. | ||
| List<File> _findIntegrationTestFiles(Directory package) { |
There was a problem hiding this comment.
nit: This function would be more efficient as a generator.
There was a problem hiding this comment.
Done. (In practice this is usually only returning one thing, but I only didn't use a generator because I often forget that's a thing in Dart.)
|
Landing on "red" since |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Jul 10, 2021
…lutter#4116) Migrates firebase-test-lab to use the new package-looping base command. Other changes: - Extracts several helpers to make the main flow easier to follow - Removes support for finding and running `*_e2e.dart` files, since we no longer use that file structure for integration tests. Part of flutter/flutter#83413
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…lutter#4116) Migrates firebase-test-lab to use the new package-looping base command. Other changes: - Extracts several helpers to make the main flow easier to follow - Removes support for finding and running `*_e2e.dart` files, since we no longer use that file structure for integration tests. Part of flutter/flutter#83413
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates firebase-test-lab to use the new package-looping base command.
Other changes:
*_e2e.dartfiles, since we no longer use that file structure for integration tests.Part of flutter/flutter#83413
Pre-launch Checklist
dart format.)[shared_preferences]///).