Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[various] Prepare plugin repo for binding API improvements #4137

Merged
merged 1 commit into from
Jul 8, 2021
Merged

[various] Prepare plugin repo for binding API improvements #4137

merged 1 commit into from
Jul 8, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 5, 2021 •
edited
Loading

Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also #4136

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Hixie Hixie requested a review from bparrishMines as a code owner July 5, 2021 22:08
@google-cla google-cla bot added the cla: yes label Jul 5, 2021
@github-actions github-actions bot added p: battery Edits files for a battery plugin p: camera p: connectivity p: sensors p: video_player p: webview_flutter Edits files for a webview_flutter plugin labels Jul 5, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Jul 5, 2021

(Only updated the changelog for plugins where the change was not in the tests or examples.)

@Hixie Hixie mentioned this pull request Jul 5, 2021
Merged
8 tasks
stuartmorgan-g
stuartmorgan-g approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor

You can now merge in master to fix the Android issues.

@Hixie
[various] Prepare plugin repo for binding API improvements
05659f0 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136
@Hixie Hixie added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 8, 2021
@fluttergithubbot fluttergithubbot merged commit d0ac2f7 into flutter:master Jul 8, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 8, 2021
@engine-flutter-autoroll
d0ac2f7 [various] Prepare plugin repo for binding API improvements (f…
fe9916b 
…lutter/plugins#4137)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 8, 2021
@engine-flutter-autoroll
d0ac2f7 [various] Prepare plugin repo for binding API improvements (f…
22bd83d 
…lutter/plugins#4137) (#86070)
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 9, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
ff4e505 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136, flutter#4137
@Hixie Hixie mentioned this pull request Jul 9, 2021
Merged
11 tasks
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 9, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
68a5225 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136, flutter#4137
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@Hixie @amantoux
[various] Prepare plugin repo for binding API improvements (flutter#4137
138f76d 
)
Ralph-Li added a commit to Insight-Timer/plugins that referenced this pull request Jul 15, 2021
@Ralph-Li
Merge branch 'upstream_master'
567ee66 
* upstream_master: (40 commits)
  [image_picker] Image picker fix camera device (flutter#3898)
  [flutter_plugin_tools] Improve license-check output (flutter#4154)
  [webview_flutter] Fix broken keyboard issue link (flutter#3266)
  [flutter_plugin_tools] Support format on Windows (flutter#4150)
  [flutter_plugin_tools] Make unit tests pass on Windows (flutter#4149)
  [image_picker_for_web] Migrate image_picker to package:cross_file (flutter#4083)
  [various] Prepare plugin repo for binding API improvements (flutter#4148)
  [quick_actions] Add const constructor (flutter#4131)
  [in_app_purchase] Add iOS currency symbol to ProductDetails (flutter#4144)
  [in_app_purchase] Added priceCurrencySymbol to SkuDetailsWrapper (flutter#4114)
  [image_picker_platform_interface] Add methods that return package:cross_file (flutter#4072)
  [flutter_plugin_tools] Improve and test 'format' (flutter#4145)
  [flutter_plugin_tools] Only check target packages in analyze (flutter#4146)
  [in_app_purchase] Fix crash when retrieveReceiptWithError gives an error. (flutter#4138)
  [video_player] Pause video when it completes (flutter#3727)
  [in_app_purchase] Add currencySymbol to ProductDetails (flutter#4115)
  [in_app_purchase] Add documentation for price change confirmations (flutter#4092)
  [camera] android-rework part 8: Supporting modules for final implementation (flutter#4054)
  [plugin_platform_interface] Fix README broken link (flutter#4143)
  [various] Prepare plugin repo for binding API improvements (flutter#4137)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@Hixie @fotiDim
[various] Prepare plugin repo for binding API improvements (flutter#4137
40eca7d 
)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: battery Edits files for a battery plugin p: camera p: connectivity p: sensors p: video_player p: webview_flutter Edits files for a webview_flutter plugin waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hixie @stuartmorgan-g @fluttergithubbot