This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter_web]: Update instructions to reflect current versions #4163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-exempt: only affects documentation |
stuartmorgan-g
suggested changes
Jul 19, 2021
| google_maps_flutter: ^0.5.28 | ||
| google_maps_flutter_web: ^0.1.0 | ||
| google_maps_flutter: ^2.0.0 | ||
| google_maps_flutter_web: ^0.3.0 |
There was a problem hiding this comment.
We should just remove this code section, and adjust the line above to say something like: [...] so you'll need to [add it explicitly](https://pub.dev/packages/google_maps_flutter_web/install)
We should get out of the business of having doomed-to-bitrot installation examples in our READMEs, and let pub.dev's dynamic page handle that.
ditman
approved these changes
Jul 19, 2021
|
Very good change, I've just merged it. Thanks!! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
google_maps_flutter_webpackageREADME.mdlists old versions in the usage description. This is confusing to users attempting to use Google Maps in Flutter for web apps.fixes: flutter/flutter#86631
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.