Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Temporarily disable googleMapsPluginIsAdded #4214

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

This test currently has an out-of-band failure on master. Ignoring to
re-open the tree.

See flutter/flutter#87566

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

…dded test

Currently has an out-of-band failure on master. Ignoring to re-open the
tree.
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmagman
jmagman previously requested changes Aug 3, 2021
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it back:

/tmp/cirrus-ci-build/packages/google_maps_flutter/google_maps_flutter/example/android/app/src/androidTest/java/io/flutter/plugins/googlemapsexample/GoogleMapsTest.java:14: error: cannot find symbol
  @Ignore("Currently failing: https://github.com/flutter/flutter/issues/87566")
   ^
  symbol:   class Ignore
  location: class GoogleMapsTest
1 error

https://cirrus-ci.com/task/5898390765568000?logs=firebase_test_lab#L168

@jmagman jmagman dismissed their stale review August 3, 2021 17:04

approved then requested changes

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when all tests pass.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor Author

Landing on red to fix breakage.

@stuartmorgan-g stuartmorgan-g merged commit 9bca9e7 into flutter:master Aug 3, 2021
@stuartmorgan-g stuartmorgan-g deleted the maps-android-test-disable branch August 3, 2021 17:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
…utter#4214)

Currently has an out-of-band failure on master. Ignoring to re-open the
tree.
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
…utter#4214)

Currently has an out-of-band failure on master. Ignoring to re-open the
tree.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants