This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] Temporarily disable googleMapsPluginIsAdded #4214
Merged
stuartmorgan-g
merged 2 commits into
flutter:master
from
stuartmorgan-g:maps-android-test-disable
Aug 3, 2021
Merged
[google_maps_flutter] Temporarily disable googleMapsPluginIsAdded #4214
stuartmorgan-g
merged 2 commits into
flutter:master
from
stuartmorgan-g:maps-android-test-disable
Aug 3, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded test Currently has an out-of-band failure on master. Ignoring to re-open the tree.
jmagman
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jmagman
previously requested changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back:
/tmp/cirrus-ci-build/packages/google_maps_flutter/google_maps_flutter/example/android/app/src/androidTest/java/io/flutter/plugins/googlemapsexample/GoogleMapsTest.java:14: error: cannot find symbol
@Ignore("Currently failing: https://github.com/flutter/flutter/issues/87566")
^
symbol: class Ignore
location: class GoogleMapsTest
1 error
https://cirrus-ci.com/task/5898390765568000?logs=firebase_test_lab#L168
jmagman
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when all tests pass.
bparrishMines
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landing on red to fix breakage. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…utter#4214) Currently has an out-of-band failure on master. Ignoring to re-open the tree.
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
…utter#4214) Currently has an out-of-band failure on master. Ignoring to re-open the tree.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test currently has an out-of-band failure on master. Ignoring to
re-open the tree.
See flutter/flutter#87566
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).