Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Enable the new Windows targets #4325

Merged
merged 2 commits into from
Sep 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 6 additions & 45 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,40 +35,11 @@ platform_properties:
os: Windows

targets:
# TODO(stuartmorgan) Remove once the renamed version below has propagated.
- name: Windows Plugins master channel
recipe: plugins/plugins
timeout: 30
properties:
add_recipes_cq: "true"
target_file: windows_build_and_platform_tests.yaml
dependencies: >
[
{"dependency": "vs_build"}
]
scheduler: luci

# TODO(stuartmorgan) Remove once the renamed version below has propagated.
- name: Windows Plugins stable channel
recipe: plugins/plugins
timeout: 30
properties:
add_recipes_cq: "true"
target_file: windows_build_and_platform_tests.yaml
channel: stable
dependencies: >
[
{"dependency": "vs_build"}
]
scheduler: luci

- name: Windows win32-platform_tests master
recipe: plugins/plugins
bringup: true
timeout: 30
properties:
# TODO(stuartmorgan): Uncomment when removing bringup.
#add_recipes_cq: "true"
add_recipes_cq: "true"
target_file: windows_build_and_platform_tests.yaml
dependencies: >
[
Expand All @@ -78,11 +49,9 @@ targets:

- name: Windows win32-platform_tests stable
recipe: plugins/plugins
bringup: true
timeout: 30
properties:
# TODO(stuartmorgan): Uncomment when removing bringup.
#add_recipes_cq: "true"
add_recipes_cq: "true"
target_file: windows_build_and_platform_tests.yaml
channel: stable
dependencies: >
Expand All @@ -93,11 +62,9 @@ targets:

- name: Windows windows-build_all_plugins master
recipe: plugins/plugins
bringup: true
timeout: 30
properties:
# TODO(stuartmorgan): Uncomment when removing bringup.
#add_recipes_cq: "true"
add_recipes_cq: "true"
target_file: build_all_plugins.yaml
dependencies: >
[
Expand All @@ -107,11 +74,9 @@ targets:

- name: Windows windows-build_all_plugins stable
recipe: plugins/plugins
bringup: true
timeout: 30
properties:
# TODO(stuartmorgan): Uncomment when removing bringup.
#add_recipes_cq: "true"
add_recipes_cq: "true"
target_file: build_all_plugins.yaml
channel: stable
dependencies: >
Expand All @@ -122,11 +87,9 @@ targets:

- name: Windows uwp-platform_tests master
recipe: plugins/plugins
bringup: true
timeout: 30
properties:
# TODO(stuartmorgan): Uncomment when removing bringup.
#add_recipes_cq: "true"
add_recipes_cq: "true"
target_file: uwp_build_and_platform_tests.yaml
dependencies: >
[
Expand All @@ -136,11 +99,9 @@ targets:

- name: Windows plugin_tools_tests
recipe: plugins/plugins
bringup: true
timeout: 30
properties:
# TODO(stuartmorgan): Uncomment when removing bringup.
#add_recipes_cq: "true"
add_recipes_cq: "true"
target_file: plugin_tools_tests.yaml
scheduler: luci

Expand Down
4 changes: 3 additions & 1 deletion script/tool/test/drive_examples_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:convert';
import 'dart:io' as io;

import 'package:args/command_runner.dart';
Expand Down Expand Up @@ -60,7 +61,8 @@ void main() {
final String output =
'''${includeBanner ? updateBanner : ''}[${devices.join(',')}]''';

final MockProcess mockDevicesProcess = MockProcess(stdout: output);
final MockProcess mockDevicesProcess =
MockProcess(stdout: output, stdoutEncoding: utf8);
processRunner
.mockProcessesForExecutable[getFlutterCommand(mockPlatform)] =
<io.Process>[mockDevicesProcess];
Expand Down