This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] Extract WKWebView implementation into a separate package #4345
Merged
mvanbeusekom
merged 13 commits into
flutter:master
from
Baseflow:webview/federated_architecture_part_4
Sep 21, 2021
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6cea90c
Setup webview_flutter_wkwebview package.
mvanbeusekom d07fa30
Direct copy of "iOS" folder.
mvanbeusekom e3fcecb
Rename .podspec file to match package name.
mvanbeusekom e8da67f
Direct copy of WKWebView specific .dart files.
mvanbeusekom 822cd97
Modify .dart code to work with new platform_interface.
mvanbeusekom 052b827
Direct copy of the `webview_flutter/example` app.
mvanbeusekom f55a01f
Update example to WKWebView specific implementation.
mvanbeusekom 8007cf9
Update integration tests.
mvanbeusekom a1f1619
Fix iOS UI tests.
mvanbeusekom e6ddab6
Point to existing documentation URL
mvanbeusekom d20e802
Split helper classes from main example widget.
mvanbeusekom 114b96e
Updated version numbers as suggested in review.
mvanbeusekom 4c772c2
Merge remote-tracking branch 'upstream/master' into webview/federated…
mvanbeusekom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
packages/webview_flutter/webview_flutter_wkwebview/AUTHORS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
# Below is a list of people and organizations that have contributed | ||
# to the Flutter project. Names should be added to the list like so: | ||
# | ||
# Name/Organization <email address> | ||
|
||
Google Inc. | ||
The Chromium Authors | ||
German Saprykin <[email protected]> | ||
Benjamin Sauer <[email protected]> | ||
[email protected] | ||
Ali Bitek <[email protected]> | ||
Pol Batlló <[email protected]> | ||
Anatoly Pulyaevskiy | ||
Hayden Flinner <[email protected]> | ||
Stefano Rodriguez <[email protected]> | ||
Salvatore Giordano <[email protected]> | ||
Brian Armstrong <[email protected]> | ||
Paul DeMarco <[email protected]> | ||
Fabricio Nogueira <[email protected]> | ||
Simon Lightfoot <[email protected]> | ||
Ashton Thomas <[email protected]> | ||
Thomas Danner <[email protected]> | ||
Diego Velásquez <[email protected]> | ||
Hajime Nakamura <[email protected]> | ||
Tuyển Vũ Xuân <[email protected]> | ||
Miguel Ruivo <[email protected]> | ||
Sarthak Verma <[email protected]> | ||
Mike Diarmid <[email protected]> | ||
Invertase <[email protected]> | ||
Elliot Hesp <[email protected]> | ||
Vince Varga <[email protected]> | ||
Aawaz Gyawali <[email protected]> | ||
EUI Limited <[email protected]> | ||
Katarina Sheremet <[email protected]> | ||
Thomas Stockx <[email protected]> | ||
Sarbagya Dhaubanjar <[email protected]> | ||
Ozkan Eksi <[email protected]> | ||
Rishab Nayak <[email protected]> | ||
ko2ic <[email protected]> | ||
Jonathan Younger <[email protected]> | ||
Jose Sanchez <[email protected]> | ||
Debkanchan Samadder <[email protected]> | ||
Audrius Karosevicius <[email protected]> | ||
Lukasz Piliszczuk <[email protected]> | ||
SoundReply Solutions GmbH <[email protected]> | ||
Rafal Wachol <[email protected]> | ||
Pau Picas <[email protected]> | ||
Christian Weder <[email protected]> | ||
Alexandru Tuca <[email protected]> | ||
Christian Weder <[email protected]> | ||
Rhodes Davis Jr. <[email protected]> | ||
Luigi Agosti <[email protected]> | ||
Quentin Le Guennec <[email protected]> | ||
Koushik Ravikumar <[email protected]> | ||
Nissim Dsilva <[email protected]> | ||
Giancarlo Rocha <[email protected]> | ||
Ryo Miyake <[email protected]> | ||
Théo Champion <[email protected]> | ||
Kazuki Yamaguchi <[email protected]> | ||
Eitan Schwartz <[email protected]> | ||
Chris Rutkowski <[email protected]> | ||
Juan Alvarez <[email protected]> | ||
Aleksandr Yurkovskiy <[email protected]> | ||
Anton Borries <[email protected]> | ||
Alex Li <[email protected]> | ||
Rahul Raj <[email protected]> | ||
Maurits van Beusekom <[email protected]> |
3 changes: 3 additions & 0 deletions
3
packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
## 0.0.1 | ||
|
||
* Extract WKWebView implementation from `webview_flutter`. |
25 changes: 25 additions & 0 deletions
25
packages/webview_flutter/webview_flutter_wkwebview/LICENSE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
Copyright 2013 The Flutter Authors. All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without modification, | ||
are permitted provided that the following conditions are met: | ||
|
||
* Redistributions of source code must retain the above copyright | ||
notice, this list of conditions and the following disclaimer. | ||
* Redistributions in binary form must reproduce the above | ||
copyright notice, this list of conditions and the following | ||
disclaimer in the documentation and/or other materials provided | ||
with the distribution. | ||
* Neither the name of Google Inc. nor the names of its | ||
contributors may be used to endorse or promote products derived | ||
from this software without specific prior written permission. | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND | ||
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR | ||
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON | ||
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
11 changes: 11 additions & 0 deletions
11
packages/webview_flutter/webview_flutter_wkwebview/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# webview\_flutter\_wkwebview | ||
|
||
The Apple WKWebView implementation of [`webview_flutter`][1]. | ||
|
||
## Usage | ||
|
||
This package is [endorsed][2], which means you can simply use `webview_flutter` | ||
normally. This package will be automatically included in your app when you do. | ||
|
||
[1]: https://pub.dev/packages/webview_flutter | ||
[2]: https://flutter.dev/docs/development/packages-and-plugins/developing-packages#endorsed-federated-plugin |
29 changes: 29 additions & 0 deletions
29
packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: webview_flutter_wkwebview | ||
description: A Flutter plugin that provides a WebView widget based on Apple's WKWebView control. | ||
repository: https://github.com/flutter/plugins/tree/master/packages/webview_flutter/webview_flutter_wkwebview | ||
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 | ||
version: 0.0.1 | ||
|
||
environment: | ||
sdk: ">=2.12.0 <3.0.0" | ||
flutter: ">=2.0.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To avoid a follow-up PR: this can be 2.14 and 2.5 respectively, since we aren't supporting iOS 8 now. We're in the process of updating plugins accordingly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
|
||
flutter: | ||
plugin: | ||
implements: webview_flutter | ||
platforms: | ||
ios: | ||
pluginClass: FLTWebViewFlutterPlugin | ||
|
||
dependencies: | ||
flutter: | ||
sdk: flutter | ||
|
||
webview_flutter_platform_interface: ^1.0.0 | ||
|
||
dev_dependencies: | ||
flutter_driver: | ||
sdk: flutter | ||
flutter_test: | ||
sdk: flutter | ||
pedantic: ^1.10.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Let's use the current flutter_webview version as a starting point. It's kind of weird to have it look like this is a completely new thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree and updated the version to 2.0.13 (same as current webview_flutter package).