-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera]rename dispatchQueue to captureSessionQueue #4687
[camera]rename dispatchQueue to captureSessionQueue #4687
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
You're right, but you should still get a test exemption from @Hixie in Discord.
@stuartmorgan we usually still do a CHANGELOG |
I moved us to a policy of generally requiring a CHANGELOG change for everything—see the last sentence of https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog for my rationale—which is why |
In this case I would lean toward:
or something like that. Mostly because if there were some subtle bug introduced by the rename that we didn't notice until the next |
d6496cc
to
f11c90e
Compare
test-exempt: code refactor with no semantic change |
@stuartmorgan updated the changelog. ptal thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rename the queue to be aligned with the proposal.
I am keeping this PR small and only scoped to renaming.
Since it's just renaming, I think it's exempt from version bump and unit test
Issue:
flutter/flutter#96429
No version change: Because it's only renaming
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.*CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.*///
).