Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera]rename dispatchQueue to captureSessionQueue #4687

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Jan 21, 2022

Rename the queue to be aligned with the proposal.

I am keeping this PR small and only scoped to renaming.

Since it's just renaming, I think it's exempt from version bump and unit test

Issue:
flutter/flutter#96429

No version change: Because it's only renaming

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.*
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.*
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman
Copy link
Member

jmagman commented Jan 21, 2022

I think it's exempt from unit test

You're right, but you should still get a test exemption from @Hixie in Discord.

If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

@stuartmorgan we usually still do a CHANGELOG NEXT when the version isn't bumped? Or do you not bother on little changes?

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan we usually still do a CHANGELOG NEXT when the version isn't bumped? Or do you not bother on little changes?

I moved us to a policy of generally requiring a CHANGELOG change for everything—see the last sentence of https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog for my rationale—which is why publishable is strict about it. But it's kind of a trial; if it turns out to be annoying in practice we can easily relax the policy and change the tooling to only require it when the version changes.

@stuartmorgan-g
Copy link
Contributor

In this case I would lean toward:

## NEXT

* Minor internal code cleanup.

or something like that. Mostly because if there were some subtle bug introduced by the rename that we didn't notice until the next camera release, it would make it easier for us to realize that there would be two PRs to go look at, rather than potentially being misled by the CHANGELOG and looking at only the last change.

@Hixie
Copy link
Contributor

Hixie commented Jan 21, 2022

test-exempt: code refactor with no semantic change

@hellohuanlin
Copy link
Contributor Author

@stuartmorgan updated the changelog. ptal thanks

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellohuanlin hellohuanlin added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jan 21, 2022
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests p: camera platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants