This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[various] Adopt plugin_platform_interface
#6332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches `google_sign_in` and `shared_preferences` from a logacy custom system for verifying that implementations use `extends` rather than `implements` to the now-standard `plugin_platform_interface`, deprecating the `isMock` approach to overriding it. Fixes flutter/flutter#98710 Fixes flutter/flutter#98709
11 tasks
loic-sharma
reviewed
Aug 29, 2022
...s/shared_preferences_platform_interface/test/shared_preferences_platform_interface_test.dart
Show resolved
Hide resolved
gaaclarke
reviewed
Aug 29, 2022
packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...s/shared_preferences_platform_interface/test/shared_preferences_platform_interface_test.dart
Show resolved
Hide resolved
gaaclarke
approved these changes
Aug 29, 2022
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches
google_sign_inandshared_preferencesfrom a legacy customsystem for verifying that implementations use
extendsrather thanimplementsto the now-standardplugin_platform_interface,deprecating the
isMockapproach to overriding it.Fixes flutter/flutter#98710
Fixes flutter/flutter#98709
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).