Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Update NSPhotoLibraryUsageDescription description in README #6589

Merged
merged 2 commits into from
Feb 17, 2023
Merged

[image_picker] Update NSPhotoLibraryUsageDescription description in README #6589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968bb0d
Update `NSPhotoLibraryUsageDescription` description in README
jmagman Oct 18, 2022
e0cc86d
Update text about App Store policy
jmagman Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/image_picker/image_picker/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## NEXT
## 0.8.6+2

* Updates `NSPhotoLibraryUsageDescription` description in README.

* Updates minimum Flutter version to 3.0.

Expand Down
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ As a result of implementing PHPicker it becomes impossible to pick HEIC images o
Add the following keys to your _Info.plist_ file, located in `<project root>/ios/Runner/Info.plist`:

* `NSPhotoLibraryUsageDescription` - describe why your app needs permission for the photo library. This is called _Privacy - Photo Library Usage Description_ in the visual editor.
* This permission is not required for image picking on iOS 11+ if you pass `false` for `requestFullMetadata`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you want to remove it fully, but maybe instead we should leave it but change to something like "This permission will not be requested if you always pass false for requestFullMetadata, but App Store policy requires including the plist entry."

That way people (including future us, potentially) won't think it's a mistake that we're listing it here when they read the code documentation that talks about how that flag interacts with permissions.

* This permission will not be requested if you always pass `false` for `requestFullMetadata`, but App Store policy requires including the plist entry.
* `NSCameraUsageDescription` - describe why your app needs access to the camera. This is called _Privacy - Camera Usage Description_ in the visual editor.
* `NSMicrophoneUsageDescription` - describe why your app needs access to the microphone, if you intend to record videos. This is called _Privacy - Microphone Usage Description_ in the visual editor.

Expand Down
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for selecting images from the Android and iOS image
library, and taking new pictures with the camera.
repository: https://github.com/flutter/plugins/tree/main/packages/image_picker/image_picker
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
version: 0.8.6+1
version: 0.8.6+2

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down