Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick_actions] Fix Android integration test flake #6688

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[quick_actions] Fix Android integration test flake #6688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
640e7f7
Make fix
camsim99 Nov 9, 2022
3fd413c
Formatting
camsim99 Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...oid/app/src/androidTest/java/io/flutter/plugins/quickactionsexample/QuickActionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;

Expand Down Expand Up @@ -86,9 +85,6 @@ public void appShortcutsAreCreated() {
}
}

// TODO(bparrishMines): The test is ignored because it fails when ran on Firebase Test Lab. See
// https://github.com/flutter/flutter/issues/114246.
@Ignore
@Test
public void appShortcutLaunchActivityAfterStarting() {
// Arrange
Expand Down Expand Up @@ -119,7 +115,7 @@ public void appShortcutLaunchActivityAfterStarting() {
"AppShortcut:" + firstShortcut.getId() + " does not launch the correct activity",
// We can only find the shortcut type in content description while inspecting it in Ui
// Automator Viewer.
device.hasObject(By.desc(firstShortcut.getId() + appReadySentinel)));
device.hasObject(By.descContains(firstShortcut.getId() + appReadySentinel)));
// This is Android SingleTop behavior in which Android does not destroy the initial activity and
// launch a new activity.
Assert.assertEquals(initialActivity.get(), currentActivity.get());
Expand Down