This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[local_auth] Fix failed biometric authentication not throwing error #6821
Merged
Merged
Changes from 8 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
684790a
fix failed biometric authentication not throwing error + tests
LouiseHsu 89ba69c
fix test names
LouiseHsu 823843d
Revert "fix test names"
LouiseHsu 3da994d
Revert "fix failed biometric authentication not throwing error + tests"
LouiseHsu 714907d
fix authentication not throwing error + tests
LouiseHsu abb8e68
fix test name
LouiseHsu b7bbcab
auto format
LouiseHsu cc7e32f
cr fixes
LouiseHsu 0bcffeb
addressed pr comments
LouiseHsu 5a545bd
formatting
LouiseHsu 1a053b2
formatting
LouiseHsu 2a64876
formatting
LouiseHsu 2583cc4
format attempt
LouiseHsu 40a00cf
format attempt
LouiseHsu 0ac9aee
formatting fixes
LouiseHsu 699a612
change incorrect versionning
LouiseHsu b483520
fix test
LouiseHsu 737bbd1
add back macro
LouiseHsu f62195a
fixed up tests, removed unnecessary assertions, replaced isAMemberOf
LouiseHsu 56d4969
add back error for unknown error codes
LouiseHsu 99e34ca
tests
LouiseHsu c70c8bc
changed enum to something thats not deprecated
LouiseHsu 42682f2
remove redundant test
LouiseHsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No updates to
local_auth
are needed in this case, just the implementation package.