This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[shared_preferences] Revert recent iOS example changes #6955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for Objective-C apps (flutter#6952)" This reverts commit be2e3de.
flutter#6940)" This reverts commit 44098fe.
stuartmorgan-g
added
the
override: no changelog needed
|
No changelog changes needed since it's just build details of the example, and unit tests. |
tarrinneal
approved these changes
Jan 13, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2023
* d607cd910 Roll Flutter from 0d91c03 to 2201698 (28 revisions) (flutter/plugins#6953) * e2d174ca1 [tool] Check for search paths in Swift plugins (flutter/plugins#6954) * f80aabf03 [shared_preferences] Revert recent iOS example changes (flutter/plugins#6955) * f36fa6407 [android_webview_controller] Fixes bug where an `AndroidController` couldn't be reused (flutter/plugins#6910) * b751ff166 [webview_flutter_android] Fixes crash when the Java `InstanceManager` was used after plugin was removed from engine (flutter/plugins#6943) * 1efd51837 Roll Flutter from 2201698 to 68dd63d (9 revisions) (flutter/plugins#6956) * eda98cddb Roll Flutter from 68dd63d to 1220245 (4 revisions) (flutter/plugins#6957) * 4e5cf2d2d Roll Flutter from 1220245 to 8c2fdb8 (2 revisions) (flutter/plugins#6979)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#118624) * d607cd910 Roll Flutter from 0d91c03 to 2201698 (28 revisions) (flutter/plugins#6953) * e2d174ca1 [tool] Check for search paths in Swift plugins (flutter/plugins#6954) * f80aabf03 [shared_preferences] Revert recent iOS example changes (flutter/plugins#6955) * f36fa6407 [android_webview_controller] Fixes bug where an `AndroidController` couldn't be reused (flutter/plugins#6910) * b751ff166 [webview_flutter_android] Fixes crash when the Java `InstanceManager` was used after plugin was removed from engine (flutter/plugins#6943) * 1efd51837 Roll Flutter from 2201698 to 68dd63d (9 revisions) (flutter/plugins#6956) * eda98cddb Roll Flutter from 68dd63d to 1220245 (4 revisions) (flutter/plugins#6957) * 4e5cf2d2d Roll Flutter from 1220245 to 8c2fdb8 (2 revisions) (flutter/plugins#6979)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* Revert "[shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter#6952)" This reverts commit be2e3de. * Revert "[shared_preferences] Switch to `shared_preferences_foundation` (flutter#6940)" This reverts commit 44098fe. * Re-apply the non-example parts of the reverted PRs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts:
shared_preferencesiOS example recreation from [shared_preferences] Switch toshared_preferences_foundation#6940in_app_purchase_storekitiOS platform tests failing on master, crashing during native tests flutter#118418shared_preferences_foundationiOS example changes from [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps #6952This combination will give us entirely Swift within the implementation package, which is useful for development (especially the unit tests), and backstop coverage that shared_preferences works in an Obj-C project that, while it will still only catch issues post-publish, will be within the plugin group so less mysterious and easier to associate back to the relevant recent change. (And the new explicit podspec check will prevent this particular regression pre-publish, so that's just a general backstop against any unexpected future project type mismatch issues.)
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).