Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Ignore deprecated member use on DecoderBufferCallback #7014

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Ignore deprecated member use on DecoderBufferCallback #7014

merged 2 commits into from
Jan 25, 2023

Conversation

tvolkert
Copy link
Contributor

In preparation for flutter/flutter#118966

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tvolkert tvolkert requested a review from Piinks January 24, 2023 08:05
Piinks
Piinks approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo test exception from Hixie 👍

@Hixie
Copy link
Contributor

Hixie commented Jan 24, 2023

test-exempt: avoids future broken tests

@tvolkert tvolkert added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2023
@auto-submit
Copy link

auto-submit bot commented Jan 25, 2023

auto label is removed for flutter/plugins, pr: 7014, Failed to merge pr#: 7014 with Pull request could not be merged: Pull Request is not mergeable.

@tvolkert tvolkert added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2023
@auto-submit auto-submit bot merged commit 8bab180 into flutter:main Jan 25, 2023
@tvolkert tvolkert deleted the linter branch January 25, 2023 03:16
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@tvolkert @mauricioluz
Ignore deprecated member use on DecoderBufferCallback (flutter#7014)
67d418b 
* Ignore deprecated member use on DecoderBufferCallback

In preparation for flutter/flutter#118966

* Bump version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: ios_platform_images
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvolkert @Hixie @Piinks