This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[various] Standardize the extension for Pigeon-generated Dart #7029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
cbracken,
cyanglaz,
hellohuanlin,
vashworth,
jmagman,
camsim99 and
bparrishMines
as code owners
github-actions
bot
added
p: camera
p: file_selector
p: image_picker
p: video_player
p: webview_flutter
hellohuanlin
approved these changes
Jan 25, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2023
* 8f83dc29b [various] Standardize the extension for Pigeon-generated Dart (flutter/plugins#7029) * 8fcff8756 Roll Flutter from 75680ae to 0a22a1d (3 revisions) (flutter/plugins#7051) * 3d81a0071 [tool] More main-branch detection improvement (flutter/plugins#7067) * e41f9f95e [ci] Clean up analysis options (flutter/plugins#7068) * 4cf6f4494 [in_app_puchase_storekit] handle `appStoreReceiptURL` is nil (flutter/plugins#7069) * d5bab1668 prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable (flutter/plugins#6847) * 36d8066cf Roll Flutter from 0a22a1d to d278808 (58 revisions) (flutter/plugins#7078) * ec463866f [various] prepare for more const widgets (flutter/plugins#7074) * dbf8d8d07 Change google_sign_in_ios and image_picker_ios owners (flutter/plugins#7070) * 1d4570bb0 Update README.md (flutter/plugins#7076) * 9302d87ee [ci] More cirrus.yml pre-alignment with flutter/packages (flutter/plugins#7079)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize on
.g.dartfor all Dart Pigeon output. Per previous discussion with @gaaclarke, this is the convention used by packages likejson_serializablefor generated code, so it makes sense to be consistent with that. Most of our recent Pigeon additions have followed that convention, so it's already the common case in the repo.This makes the repository more consistent, and reduces the number of special-case analysis exclusions we need.
As a minor opportunistic change, this updates the repo tooling to recognize
pigeons/as a dev-only path; that was necessary to makeupdate-release-infowork as desired on this PR.Part of flutter/flutter#113764
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.