Skip to content

Adds "Launching a Compose activity" article #11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 11, 2024
Merged

Conversation

craiglabenz
Copy link
Contributor

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@craiglabenz craiglabenz requested review from sfshaza2, parlough and a team as code owners October 2, 2024 17:12
@craiglabenz craiglabenz requested a review from jwill October 2, 2024 17:12
@craiglabenz
Copy link
Contributor Author

Extra fiddling with the website's actual build mechanics may be required, but I haven't ever used the new system so I'm not sure. This is just the raw content for our new article.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 2, 2024

Visit the preview URL for this PR (updated for commit 72c4c5f):

https://flutter-docs-prod--pr11219-compose-activity-docs-t1pgdlom.web.app

@craiglabenz
Copy link
Contributor Author

There seems to a small gap in documentation around the excerpter package. When attempting to run the site, I am seeing this error:

$ ./dash_site serve                  
Verifying npm dependencies are up to date...
Resolving dependencies in `/Users/craiglabenz/Dev/git/flutter/website`... 
Because every version of flutter_site from path depends on excerpter from path which doesn't exist (could not find package excerpter at "site-shared/packages/excerpter"), flutter_site from path
  is forbidden.
So, because docs_flutter_dev depends on flutter_site from path, version solving failed.

Is there a specific way to install that package?

@parlough
Copy link
Member

parlough commented Oct 2, 2024

@craiglabenz You might be missing the site-shared submodule. Can you try reinitializing it?

git submodule update --init --recursive

Then run dart pub get from the root directory:

dart pub get
./dash_site serve

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Overall, it's looking good!

@jwill
Copy link
Contributor

jwill commented Oct 2, 2024

Good progress, but...
Consider expanding the top level paragraph describing the approximate flow of what needs to be done with a bit more detail...or extra credit a diagram as well. As currently written, it feels like it jumps into on the dart side/on the android side.

I might think about adding links to things associated with platform methods, or the tutorial page if one exists.

@craiglabenz
Copy link
Contributor Author

Thanks, @parlough! It didn't occur to me that I might be missing a submodule - but I'd originally cloned this repo ages ago, so I was.

Local development is working for me now :)

@sfshaza2
Copy link
Contributor

sfshaza2 commented Oct 3, 2024

@craiglabenz, if you look at the CI detailed results of running "Test", the template has a problem:

Error: There were errors when updating excerpts!
Error: Process completed with exit code 1.
Error: The step failed and an error occurred when attempting to determine whether to continue on error.
Error: The template is not valid. .github/workflows/test.yml (Line: 70, Col: 28): Unexpected value ''

@craiglabenz
Copy link
Contributor Author

This looks ready for final review from a codeowner, @parlough 😄

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. But am also leaving for either @parlough or @ewindmill (on deck this week) to review.

Copy link
Contributor

@ericwindmill ericwindmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2
Copy link
Contributor

sfshaza2 commented Oct 9, 2024

I'm confused. How does this overlap with this: #11232 ?

@jwill
Copy link
Contributor

jwill commented Oct 9, 2024

#11219 and #11232 do not overlap.

@sfshaza2 sfshaza2 merged commit e565f7e into main Oct 11, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the compose-activity-docs branch October 11, 2024 16:13
@sfshaza2
Copy link
Contributor

You are right. I realize that now. I really dug into this late last week. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants