-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Adds "Launching a Compose activity" article #11219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Extra fiddling with the website's actual build mechanics may be required, but I haven't ever used the new system so I'm not sure. This is just the raw content for our new article. |
Visit the preview URL for this PR (updated for commit 72c4c5f): https://flutter-docs-prod--pr11219-compose-activity-docs-t1pgdlom.web.app |
There seems to a small gap in documentation around the
Is there a specific way to install that package? |
@craiglabenz You might be missing the
Then run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits. Overall, it's looking good!
Good progress, but... I might think about adding links to things associated with platform methods, or the tutorial page if one exists. |
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Thanks, @parlough! It didn't occur to me that I might be missing a submodule - but I'd originally cloned this repo ages ago, so I was. Local development is working for me now :) |
@craiglabenz, if you look at the CI detailed results of running "Test", the template has a problem:
|
This looks ready for final review from a codeowner, @parlough 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. But am also leaving for either @parlough or @ewindmill (on deck this week) to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm confused. How does this overlap with this: #11232 ? |
You are right. I realize that now. I really dug into this late last week. Thanks again. |
Presubmit checklist