package_info_plus for windows returns invalid string

[Farer]

As you see above it returns invalid string.
I guessed that is blank string.
Buy it's not blank.
So I can't parse it as int.
Could you fix it ?

[p3root]

It also returns always just "1.0.0 ". I have a different version number in my pubspec file

[narumi147]

The last char is \x000. So should all values be trimmed in getValue?

plus_plugins/packages/package_info_plus_windows/lib/src/file_version_info.dart

Line 48 in 2085d1c

String? getValue(String name) {

can anyone have a quick fix on it?

The \x000 may be cause by such code \0 in generated windows/runner/Runner.rc

BEGIN
    BLOCK "StringFileInfo"
    BEGIN
        BLOCK "040904e4"
        BEGIN
            VALUE "CompanyName", "com.example" "\0"
            VALUE "FileDescription", "A new Flutter project." "\0"
            VALUE "FileVersion", VERSION_AS_STRING "\0"
            VALUE "InternalName", "example" "\0"
            VALUE "LegalCopyright", "Copyright (C) 2021 com.example. All rights reserved." "\0"
            VALUE "OriginalFilename", "example.exe" "\0"
            VALUE "ProductName", "example" "\0"
            VALUE "ProductVersion", VERSION_AS_STRING "\0"
        END
    END
    BLOCK "VarFileInfo"
    BEGIN
        VALUE "Translation", 0x409, 1252
    END
END

BTW @p3root flutter hasn't implement generating version for exe from pubspec yet, it's not an issue of this plugin

[p3root]

Any workaroung for that?

[narumi147]

@p3root please tracking flutter/flutter#73652

[narumi147]

@p3root if you want to update exe version, you can edit windows/runner/Runner.rc. Just change the default value for VERSION_AS_NUMBER and VERSION_AS_STRING. This is my current solution before official support. You will need to change it manually every time changing version.

#ifdef FLUTTER_BUILD_NUMBER
#define VERSION_AS_NUMBER FLUTTER_BUILD_NUMBER
#else
#define VERSION_AS_NUMBER 1,3,8,33
#endif

#ifdef FLUTTER_BUILD_NAME
#define VERSION_AS_STRING #FLUTTER_BUILD_NAME
#else
#define VERSION_AS_STRING "1.3.8.33"
#endif

The original should be x.y.z and "x.y.z", I add build number after. If you want to use package_info_plus to parse it, you should change 1.3.8.33 to 1.3.8+33 in my example.

[mhadaily]

duplicate #343

reason: flutter/flutter#73652

[fabiancrx]

This issue could be closed and continue tracking at #343 as @mhadaily stated.