Work around PackageInfo Limitations

[ueman]

Linux und Windows have a few limitations. Notably:

• Linux has no package name
• Windows has an empty distribution

We need to figure out what a sensible default value is, if we can not work around those limitations.

[marandaneto]

Current linux release: @0.1.2+3
Current windows release: sentry_flutter_example\[email protected]\u0000+ -> https://www.fileformat.info/info/unicode/char/0000/index.htm

[marandaneto]

macOS does it nicely [email protected]+3

[marandaneto]

windows issue fluttercommunity/plus_plugins#182 and flutter/flutter#73652

[marandaneto]

linux issue fluttercommunity/plus_plugins#203

[ueman]

https://www.github.com/fluttercommunity/plus_plugins/tree/main/packages%2Fpackage_info_plus_linux%2Flib%2Fsrc%2Fpackage_info.dart

https://www.github.com/fluttercommunity/plus_plugins/tree/main/packages%2Fpackage_info_plus_web%2Flib%2Fpackage_info_plus_web.dart

Web is also missing the package identifier like linux. Maybe we could use the app name if no package identifier is available.

[marandaneto]

@ueman sounds a good idea
there are a few chars not allowed chars though, https://docs.sentry.io/platforms/flutter/configuration/releases/#bind-the-version
packageName does not allow such chars, so we have not used a regex or so, maybe with App's name this might be necessary.

[ueman]

On web and linux and windows the name given in the pubspec.yaml gets used as appName: https://dart.dev/tools/pub/pubspec#name

I'm not sure though about windows and what UWP uses though.

[marandaneto]

to close this issue I suggest the following:

take the Windows example:

sentry_flutter_example\[email protected]\u0000+

trim null chars \u0000;
only concat + if the buildNumber is non-empty;

result should be: [email protected]

other than that, on Windows support, we should document that the release should be set by either options.release or SENTRY_RELEASE env. var.

[ueman]

Do we want to do

trim null chars \u0000;

ourself or do we fix it in package_info_plus?

[marandaneto]

@ueman we can't control user's package_info_plus version, so we have to trim ourselves, I believe, otherwise we'd force people to a min. version which is the latest and might not be what they want.