Skip to content

[package_info_plus] Added supported platforms to README.md #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

nilsreichardt
Copy link
Contributor

Description

When I read the README.md of package_info_plus it wasn't for me clear, which platforms are supported. You can see it maybe with the dependencies like package_info_plus_linux. However, it is very hidden. And in the description of the pubspec.yaml, which will be displayed at the right side, mentioning only Android & iOS which is confusing (My thoughts: Why not also mention Linux, Web, macOS and Windows? Or is there no support for this platforms)?

Demo

image

Related Issues

Part of #111

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@nilsreichardt
Copy link
Contributor Author

Should I also add the other packages to this PR or should I split it in many small PRs (like this PR)?

@miquelbeltran
Copy link
Member

@nilsreichardt I don't mind either way, however works best for you!

Also @pr-Mais was planning to do this, you should coordinate so you are not doing the work twice.

@pr-Mais
Copy link
Member

pr-Mais commented Feb 4, 2021

@nilsreichardt thanks for the PR, I was just thinking of doing one, you can add the supported platforms for all of them, I will be working on adding more examples, so we won't conflict each others.

@nilsreichardt
Copy link
Contributor Author

@pr-Mais I you want you take over. I did this for package_info_plus so I cloud create a screenshot for #111.

@pr-Mais
Copy link
Member

pr-Mais commented Feb 4, 2021

@nilsreichardt alright I will continue for the rest, thanks!

@nilsreichardt
Copy link
Contributor Author

@pr-Mais Great! Maybe you can assign yourself to #111, so other people see that you doing this ticket.

@pr-Mais
Copy link
Member

pr-Mais commented Feb 4, 2021

@nilsreichardt done :)

@miquelbeltran
Copy link
Member

@pr-Mais I will merge this one meanwhile, you will have to create a new PR for the rest.

@miquelbeltran miquelbeltran merged commit 2f53cc9 into fluttercommunity:main Feb 4, 2021
@pr-Mais
Copy link
Member

pr-Mais commented Feb 4, 2021

@miquelbeltran noted

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants