Skip to content

[all] melos analyzer support null safety #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Feb 4, 2021

Small change to setup null safety in the analyzer used by melos.

Two exceptions need to be done for the example project in android_intent_plus and in package_info_plus

@miquelbeltran miquelbeltran changed the title [experiment?] melos analyzer support null safety [all] melos analyzer support null safety Feb 4, 2021
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so that I understand, do we need to add those temporary analysis options to each example when migrating the respective package to null-safety? And then we can clean up and remove the temporary analysis options once all packages have been migrated?

@miquelbeltran
Copy link
Member Author

Just so that I understand, do we need to add those temporary analysis options to each example when migrating the respective package to null-safety?

Kind of, only two examples seem to be affected by this issue. The example in package_info_plus complained while package_info_plus has not been migrated yet (???) and the example inside android_alarm_manager_plus didn't complain, but the package is migrated. So it may be it is just those two.

And then we can clean up and remove the temporary analysis options once all packages have been migrated?

We can clean them up when we migrate the example to null safety, at the moment the blocker is the integration_test package, which will come as part of the SDK rather than a package in pub.dev.

@jpnurmi
Copy link
Member

jpnurmi commented Feb 4, 2021

Oh ok, thanks! Good to know that it's about the example itself, not the other packages.

@miquelbeltran miquelbeltran merged commit 9fa5929 into main Feb 4, 2021
@miquelbeltran miquelbeltran deleted the melos-nullsafety branch February 4, 2021 14:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants