Skip to content

[package_info_plus_web] Added integration tests #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

yash1200
Copy link
Contributor

Description

In this PR, I have removed unnecessary map in the package_info_plus_web/lib/package_info_plus_web.dart file and added integration tests for package_info_plus_web plugin.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily mhadaily self-requested a review October 14, 2020 12:46
@mhadaily mhadaily added the package_info_plus stuff related to package_info_plus label Oct 14, 2020
@@ -1,3 +1,7 @@
## 0.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yash1200, I think we should not manually update the CHANGELOG.md on PRs, this will be done by the project maintainers on release.

In the https://github.com/fluttercommunity/plus_plugins/blob/main/CONTRIBUTING.md file we explain it better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't see that. I have reverted the package version.

buildNumber: map['buildNumber'],
appName: versionMap['app_name'],
version: versionMap['version'],
buildNumber: versionMap['build_number'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup!

@@ -1,7 +1,7 @@
name: package_info_plus_web
description: Web platform implementation of package_info_plus
homepage: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/package_info_plus_web
version: 0.1.0
version: 0.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained before, we will take care of updating the package version number when releasing.

@miquelbeltran
Copy link
Member

Regarding the integration tests, there's already integration tests for the package_info_plus here: https://github.com/fluttercommunity/plus_plugins/blob/main/packages/package_info_plus/example/test_driver/package_info_e2e.dart which already cover Web.

Or is this another kind of test?

@yash1200
Copy link
Contributor Author

The tests file you mentioned expects all the values in web to be null, and also I think it will be more efficient for separate platform packages to have individual tests.

@miquelbeltran
Copy link
Member

Hi @yash1200, we would like to merge the cleanup on packages/package_info_plus_web/lib/package_info_plus_web.dart, but we cannot accept the rest of the changes you proposed.

We have decided that all integration tests should go into the parent_project/example/test_driver folder except if there is a specific reason to keep them in the federated platform plugin.

If you want to continue with this PR, please revert all the changes except packages/package_info_plus_web/lib/package_info_plus_web.dart and we will merge it!

We really appreciate you contributing to the project, and thanks for taking time working on this!

@yash1200
Copy link
Contributor Author

Understandable, I have removed the tests.

@miquelbeltran miquelbeltran merged commit 25fe623 into fluttercommunity:main Oct 23, 2020
@miquelbeltran
Copy link
Member

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package_info_plus stuff related to package_info_plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants