fix(share_plus): Fix url encoding for web, Linux and Windows

[ueman]

Description

This fixes the issue mentiond in #235

Are there any existing unit tests which I can add a test to?

Related Issues

Fixes #235
Fixes #226 (at least a part of it)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[miquelbeltran]

awesome! thanks a lot.

Are there any existing unit tests which I can add a test to?

have you tried to run the e2e "integration" tests present in the main project (share_plus) on these two platforms?

[ueman]

have you tried to run the e2e "integration" tests present in the main project (share_plus) on these two platforms?

Only Web seems to have integration tests.

My idea would be to add a unit test project for each platform project.
Then I can stub the MethodChannel of the launch package and make sure that each call is correctly encoded.
Do I need to add the new test suits to any file or does it work automagically?

I also just noticed that Windows has the same problem, so I fixed that too.

[miquelbeltran]

Only Web seems to have integration tests.

The integration tests are on share_plus on purpose and execute from the example folder, they are platform agnostic. Please read the CONTRIBUTING.md document is explained there. When you run the test, you select which platform you want it to run.

(another different thing is if they work or not but that's how this project is structured)

My idea would be to add a unit test project for each platform project.
Then I can stub the MethodChannel of the launch package and make sure that each call is correctly encoded.

That would be nice, yes!

[miquelbeltran]

All good, thanks a lot!

I will merge it and release new version for share_plus_{web, linux, windows}

[miquelbeltran]

very nice!!

[stuartmorgan-g]

FYI, this is actually wrong due to a Dart bug (which is why I didn't suggest this format when I filed the issue). See dart-lang/sdk#43838, especially dart-lang/sdk#43838 (comment).

This will fix the issue I filed, but may cause spaces to be converted to + depending on the handler.

[ueman]

That's unfortunate 😅 Are there more gotchas which I should be aware of before attempting another fix?

[stuartmorgan-g]

None that I know of, no. I would suggest including spaces in the values in your unit tests on the next round, so that tests will prevent someone accidentally falling into this trap again in the future when maintaining these plugins (although hopefully the issue will be fixed in Dart itself at some point).

[miquelbeltran]

after fixing the merge issues I saw that the tests aren't passing, I will leave that to you @ueman :) once it is fix I will release the packages and merge

[miquelbeltran]

thanks for the fix! I don't know why CI is canceling the job all the time, will investigate :/

[miquelbeltran]

packages has been published