Skip to content

feat(device_info_plus): add storage information #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Binozo
Copy link
Contributor

@Binozo Binozo commented Mar 29, 2025

Description

Added storage info (total and free disk space) for Android and iOS.

Related Issues

None

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

No

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@Binozo
Copy link
Contributor Author

Binozo commented Mar 29, 2025

Hmm iOS integration test timed out but everything else seems fine

@miquelbeltran
Copy link
Member

Also looks good to me. I want to test on devices before merging. Don't worry about simulator/emulators, we have had problems with those jobs and we need to fix them someday.

@Binozo
Copy link
Contributor Author

Binozo commented Apr 14, 2025

Hey @miquelbeltran, did you have time to test this? Can I help somehow? 🙂

@miquelbeltran
Copy link
Member

Sorry @Binozo, I've been busy with the SharePlus refactor PR, I'll try to get to this asap

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on iOS and it seems fine, but I need to request a couple of changes that I missed on my first look at the code:

  1. The Android and iOS params are named differently, one is totalFreeSpace and the other is totalFreeSize, I'd prefer if the naming was consistent (or is there a reason for this?)
  2. The new params are missing in the example, they should be added as well.

Thanks again and sorry for the delay reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants