Update to Scala 3.3.0 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, so it looks like the type inference is what causes the issue. When using methods that make use of the That being said, given it's a fix that can only be done by the user, I'm not sure we should upgrade to 3.3.0 yet. Here is the stack trace of the compiler error: |
|
I ran a code snippet on the compiler code base (snippet at the end) and found out that this bug was introduced in the commit scala/scala3@b429e6b. That being said, it is fairly possible that this commit only exhibit the issue (cause of the added cast) as opposed to be the root cause of it. code snippetpackage mock
import eu.monniot.scala3mock.main.withExpectations
import eu.monniot.scala3mock.functions.MockFunctions
import eu.monniot.scala3mock.main.*
import eu.monniot.scala3mock.matchers.MatchAny
import eu.monniot.scala3mock.macros.*
import eu.monniot.scala3mock.handlers.CallHandler1
import eu.monniot.scala3mock.functions.MockFunction1
import eu.monniot.scala3mock.context.MockContext
import eu.monniot.scala3mock.main.Default
trait TestTrait {
//def polymorphic[T](x: List[T]): String
def polymorphic(x: (Int, Double)): String
def oneParam(x: List[Int]): String
}
def main(using mc: MockContext) =
val m = mock[TestTrait]
when(m.oneParam).expects(List(2))
() |
|
Confirmed that the commit only made the error apparent. When compiling the snippet under 3.2.2 with the |
|
Thanks for the investigation! I've minimized this to: class MockFunction1[T1]:
def expects(v1: T1 | Foo): Any = ???
def expects(matcher: String): Any = ???
def when[T1](f: T1 => Any): MockFunction1[T1] =
???
class Foo
def main =
val f: Foo = new Foo
when((x: Foo) => "").expects(f)I'm working on a fix currently. |
|
Oh nice! I didn't had time to work on side projects over the past two weeks, thanks for taking the time to write a minimizer! |
smarter
added a commit
to scala/scala3
that referenced
this pull request
Jul 10, 2023
This fixes the logic taking the signature of a type uninstantiated type variables (using tpnme.Uninstantiated) and non-permanently instantiated type variables (which have a legitimate signature in the currenty TyperState but cannot be cached). The test case was minimized from fmonniot/scala3mock#2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given it's the first LTS, we should try to stay on it. Although given metaprogramming is one aspect that make progress relatively quickly, maybe we will jump on a feature release (for example if the implicit/using modified is made accessible when creating functions)