Fix build error with MSVC v141 #4413
Conversation
| @@ -326,8 +326,8 @@ using underlying_t = typename std::underlying_type<T>::type; | |||
| template <typename T> using decay_t = typename std::decay<T>::type; | |||
| using nullptr_t = decltype(nullptr); | |||
|
|
|||
| #if FMT_GCC_VERSION && FMT_GCC_VERSION < 500 | |||
| // A workaround for gcc 4.9 to make void_t work in a SFINAE context. | |||
| #if (FMT_GCC_VERSION && FMT_GCC_VERSION < 500) || FMT_MSC_VERSION | |||
There was a problem hiding this comment.
Can we put more specific MSC version here?
There was a problem hiding this comment.
The MSC version depends on the Visual Studio version, but not on the platform toolset. For example:
- Visual Studio 2017 (v141 toolset) ->
_MSC_VER == 1916 - Visual Studio 2022 (v141 toolset) ->
_MSC_VER == 1943 - Visual Studio 2022 (v143 toolset) ->
_MSC_VER == 1943
Because of this, we can't accurately detect the scenario where Visual Studio 2022 is used with the v141 toolset by comparing the value of _MSC_VER. Also, I haven't found a preprocessor definition that provides the platform toolset version.
As a result, I've applied this fix to all MSVC compilers.
There was a problem hiding this comment.
OK. LGMT but please apply clang-format: https://github.com/fmtlib/fmt/actions/runs/14454504011/job/40537211039?pr=4413
There was a problem hiding this comment.
Thank you for the review. I've corrected the formatting. Also, I've updated the comment to be more accurate: MSVC 2017 -> MSVC v141.
|
Thank you |
Fixes #4412