Add PSK support #107
Closed
Add PSK support #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd really like to see this make its way in. Is there a path forward here? |
|
Needs review @alexanderheuts |
raoulstrackx
reviewed
Jul 1, 2021
| /// psk and psk_identity cannot be empty | ||
| pub fn set_psk(&mut self, psk: &[u8], psk_identity: &str) -> Result<()> { | ||
| assert!(psk_identity.len()>0); | ||
| assert!(psk.len()>0); |
There was a problem hiding this comment.
The mbedtls_ssl_conf_psk function already checks these arguments. I don't see a reason to check them here again
| where | ||
| F: FnMut(&mut HandshakeContext, &str) -> Result<()>, | ||
| { | ||
| assert!(identity_len>0); |
There was a problem hiding this comment.
Same as above, I don't see a reason for the assert.
|
|
||
| /// psk cannot be empty | ||
| pub fn set_psk(&mut self, psk: &[u8]) -> Result<()> { | ||
| assert!(psk.len()>0); |
There was a problem hiding this comment.
Same as above, I don't see a reason for the assert.
|
|
||
|
|
||
| fn client(mut conn: TcpStream, psk: &[u8]) -> TlsResult<()> { | ||
| { |
There was a problem hiding this comment.
Nitpick: this doesn't need to be in it's own block
Closed
|
Close this PR since this is outdated and PSK support is already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PSK support to the library with one basic test.