[v0.8] Move self test logic to crate mbedtls-selftest
#252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
180: Rearrange Send/Sync impls for MbedtlsList/MbedtlsBox r=AdrianCX a=jethrogb See rust-lang/rust#93367 Co-authored-by: Jethro Beekman <[email protected]>
206: Fix CI r=Pagten a=raoulstrackx A certificate used in CI expired and broke CI. This PR replaces the certificate. There's also a return value of `std::boxed::Box::<T>::from_raw` that isn't used. Co-authored-by: Raoul Strackx <[email protected]>
214: Add support for certificate revocation lists r=raoulstrackx a=monokles Originally introduced by PR #112 but never made it into master. I cherry-picked the original commits onto a fresh branch and fixed the resulting code. Since it changes the API, the version number is bumped. Co-authored-by: Raoul Strackx <[email protected]> Co-authored-by: koentange <[email protected]>
This comment was marked as duplicate.
This comment was marked as duplicate.
jethrogb
reviewed
Apr 19, 2023
|
bors try |
tryAlready running a review |
Taowyoo
force-pushed
the
yx/selftest-crate-v0.8
branch
from
9bdf743 to
fa52ef8
Compare
|
bors try |
tryAlready running a review |
|
bors cancel |
|
Backport #243 as well? |
Oh, yes, it's also needed for 0.8.X |
|
bors cancel |
tryBuild succeeded:
|
243: Namespace symbols for mbedtls_malloc to avoid conflicts. r=Taowyoo a=jethrogb Dependents of this crate may use multiple different versions of this crate. These different versions all define mbedtls_calloc and mbedtls_free, which can result in linking conflicts. Since these functions are defined in and only used by this crate, we can namespace the symbols to avoid conflicts. We use Cargo's crate disambiguator for this purpose. Co-authored-by: Jethro Beekman <[email protected]>
Taowyoo
force-pushed
the
yx/selftest-crate-v0.8
branch
from
fa52ef8 to
baef46b
Compare
|
bors try |
tryBuild failed: |
|
bors try |
|
bors cancel |
tryBuild failed: |
Use `rustc_version` conditionally add `extended_key_value_attributes` feature to fix problem: PR #243 code use unstable feature when compile with nightly-2021-03-25 rustc.
|
bors try |
tryBuild succeeded:
|
11 tasks
11 tasks
|
Close this PR, and continue work with remain in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbedtls-selftest
This Rust crate is designed for separating self-test code that needs to export Rust
functions and define C functions to be used by C
mbedtls. By separating this code,different versions of Rust
mbedtlscrates can be used within a single crate, whichhelps to solve link name conflict errors.
Note: Although multiple versions of Rust
mbedtlscrates can be used within asingle crate, only one
mbedtls-selftestand onembedtls-sys-autocrate can beused since they are built as native libraries.
Changes need attention
mbedtlsto0.8.3Cargo.tomlto ensurembedtls-selftestuse localmbedtls-sys-autocrate