Skip to content

Minor updates to README.md #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2021
Merged

Conversation

gareth-nx
Copy link
Contributor

This pull request implements the suggestion in issue 492 to explain that setting the maximum-rank reduces the compilation time with a makefile.

It also makes clear which default PREFIX directory is used when the user doesn't specify -DCMAKE_INSTALL_PREFIX. When I first used stdlib I didn't know where this was, and found it confusing.

@awvwgk awvwgk added documentation Improvements or additions to documentation reviewers needed This patch requires extra eyes labels Aug 28, 2021
@awvwgk
Copy link
Member

awvwgk commented Aug 28, 2021

@gareth-nx you might want to check your local git settings and set your commit email address. There is a no-reply address associated to your GitHub account which is usually save to use without leaking your actual email address. We can also squash your PR on merge and GitHub will automatically fix up the committer data.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@milancurcic milancurcic merged commit 12da563 into fortran-lang:master Aug 28, 2021
@gareth-nx gareth-nx deleted the pr/doc_updates branch September 19, 2021 01:38
@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants