Skip to content

inconsistent syntax highlighting for nested case-selects #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnikit opened this issue May 19, 2020 · 1 comment · Fixed by #218
Closed

inconsistent syntax highlighting for nested case-selects #181

gnikit opened this issue May 19, 2020 · 1 comment · Fixed by #218
Labels
status:fixed-waiting-merge syntax-highlight

Comments

@gnikit
Copy link
Member

gnikit commented May 19, 2020

The Modern Fortran 2 extension by @pedro-ricardo in the VS code appears to have a bug with syntax highlighting which is not present in the main Modern Fortran extension, see case(2) colouring in the figure below. Also, the highlighting with the fortran-language-server through the extension FORTRAN IntelliSense appears to be partially broken but I will raise this as a separate issue.
image
@pedro-ricardo
Copy link
Collaborator

Thanks for the report @gnikit 👍 ,
The select case received the update #165 and I don't remember testing two select case inside each other.
Will look at it

@gnikit gnikit mentioned this issue Nov 13, 2020
Closed
@gnikit gnikit changed the title Modern Fortran 2: inconsistent syntax highlighting inconsistent syntax highlighting for nested case-selects Nov 13, 2020
@gnikit gnikit mentioned this issue Feb 14, 2021
Closed
@MRedies MRedies mentioned this issue Mar 4, 2021
Closed
@gnikit gnikit mentioned this issue Mar 4, 2021
Merged
gnikit added a commit to gnikit/vscode-fortran-support that referenced this issue Mar 4, 2021
@gnikit
Fixes Modern Fortran 2: inconsistent syntax highlighting fortran-lang…
d52dd98 
…#181,

for simple case-select.

Use https://github.com/dparkins/language-fortran as a guideline
gnikit added a commit to gnikit/vscode-fortran-support that referenced this issue Mar 4, 2021
@gnikit
Fixes Modern Fortran 2: inconsistent syntax highlighting fortran-lang…
cf331ca 
…#181,

for type-select constructs.
gnikit added a commit to gnikit/vscode-fortran-support that referenced this issue Mar 4, 2021
@gnikit
Fixes Modern Fortran 2: inconsistent syntax highlighting fortran-lang…
f96360c 
…#181,

for rank-select constructs.
gnikit added a commit to gnikit/vscode-fortran-support that referenced this issue Mar 4, 2021
@gnikit
Fixes Modern Fortran 2: inconsistent syntax highlighting fortran-lang…
71620bf 
…#181,

for simple case-select.

Use https://github.com/dparkins/language-fortran as a guideline
gnikit added a commit to gnikit/vscode-fortran-support that referenced this issue Mar 4, 2021
@gnikit
Fixes Modern Fortran 2: inconsistent syntax highlighting fortran-lang…
cf39ea3 
…#181,

for type-select constructs.
gnikit added a commit to gnikit/vscode-fortran-support that referenced this issue Mar 4, 2021
@gnikit
Fixes Modern Fortran 2: inconsistent syntax highlighting fortran-lang…
4910dd1 
…#181,

for rank-select constructs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-waiting-merge syntax-highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/nested case select gnikit/vscode-fortran-support
Bug/nested case select
2 participants
@pedro-ricardo @gnikit