Feature/linter cache #611
Merged
Feature/linter cache #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change the way caching is done. A class was created
that holds the globs and the resolved and expanded paths.
On the linter side, a `Map` (has `O(1)` access) is used to
store all the VS Code options that would need a cache e.g.
`cache.set('fortran.linter.option', new GlobPaths(globs))`.
Possible performance improvements:
- Use Sets instead of Arrays
- Prefetch certain directories
TODO:
- Add unittests for linter integration
No changes to the API have been done
Tests check that - internal variables and glob patterns are resolved - caching works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves caching of paths, variables and glob patterns, while also generalising the caching framework.
This is meant to be merged into #591 to allow for more efficient resolution of linter and fypp include paths.
Also adds unittests for linting integration and caching.