arcv: simplify multilib configurations and cover more cases #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove Zicsr from all configurations. It's not necessary anymore since crt0 in Newlib and Picolibc is built with Zicsr extension explicitly. 2. Remove Zcmp from all configurations. It may reduce performance significantly but the gain in library size is minimal. 3. Remove Zcmt from all configurations. GCC does not produce Zcmt code by default. 4. Add more general configurations for testing. Signed-off-by: Yuriy Kolerov <[email protected]>
| arcv_march_variants += rv32imac_zcb_zba_zbb_zbs_zfinx | ||
| arcv_march_variants += rv32imac_zcb_zba_zbb_zbs_zfinx_zdinx | ||
| arcv_march_variants += rv32i_zba_zbb_zbs | ||
| arcv_march_variants += rv32im_zba_zbb_zbs |
There was a problem hiding this comment.
IIRC, the most critical insns for strcmp() are or.b and rev8 which are both part of Zbb. Should we create a fallback without Zba and Zbs, but with Zbb?
There was a problem hiding this comment.
I don't think that it's reasonable now. There could be too many of such fallbacks with a single zbb for all possible variants of march.
Add rv32em and rv32ema configurations.
artemiy-volkov
approved these changes
Mar 28, 2025
|
@abrodkin Could you please take a look at this new list? |
|
What I'd like to see in that PR description at least:
|
|
@abrodkin I updated PR's description. |
We have 4 -mtune values for ARC-V targets: 1. arc-v-rmx-100-series 2. arc-v-rmx-500-series 3. arc-v-rhx-100-series 4. arc-v-rpx-100-series When all of them are mentioned in a multilib configuration file (t-arcv for ARC-V) and arc-v-rmx-100-series is a default -mtune value (-with-tune= configuration option for GCC), then GCC cannot build with default target options (like gcc app.c -o app). To fix this we had to use -with-tune=rocket. However, with such approach we have to pass -mtune for a particular ARC-V target manually and not rely on RMX-100 as a default target. This patch removes -mtune from t-arcv for all RMX-100 targets and sets -with-tune=arc-v-rmx-100-series if it's not set explicitly (it corresponds to -with-tune=default). This allows using -mtune=arc-v-rmx-100-series as default without passing extra configuration options to GCC build scripts and fixes that bug with default target options. Signed-off-by: Yuriy Kolerov <[email protected]>
|
@artemiy-volkov @abrodkin I pushed another patch (d067383) that also allows using |
abrodkin
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Zicsrfrom all configurations. It's not necessary anymore sincecrt0in Newlib and Picolibc is built withZicsrextension explicitly.Zcmpfrom all configurations. It may reduce performance significantly but the gain in library size is minimal.Zcmtfrom all configurations. GCC does not produceZcmtcode by default.Toolchain's size
When installed the toolchain occupies ~13GB. A compressed
tar.xzarchive (LZMA) occupies ~1.3GB with maximum compression rate.List of RMX-100 mini configurations
-mtune=arc-v-rmx-100-series.-mcmodel=medlow.marchmabirv32eilp32erv32emilp32erv32eailp32erv32emailp32erv32emac_zcb_zba_zbb_zbs_zfinx_zdinxilp32eList of RMX-100 configurations
-mtune=arc-v-rmx-100-series.-mcmodel=medlow.zcb_zba_zbb_zbsset. All optimized configurations include them. However, usingCextensions may lead to performance decrease for RMX-100, thus additional optimized configurations withoutCare shipped too.marchmabirv32iilp32rv32icilp32rv32imilp32rv32iailp32rv32imailp32rv32iacilp32rv32imacilp32rv32ic_zcb_zba_zbb_zbsilp32rv32imc_zcb_zba_zbb_zbsilp32rv32imac_zcb_zba_zbb_zbsilp32rv32imac_zcb_zba_zbb_zbs_zfinxilp32rv32imac_zcb_zba_zbb_zbs_zfinx_zdinxilp32rv32i_zba_zbb_zbsilp32Crv32im_zba_zbb_zbsilp32Crv32ima_zba_zbb_zbsilp32Crv32ima_zba_zbb_zbs_zfinxilp32Cwith SP FPUrv32ima_zba_zbb_zbs_zfinx_zdinxilp32Cwith DP FPUList of RMX-500 configurations
-mtune=arc-v-rmx-500-series.-mcmodel=medlow.zcb_zba_zbb_zbsset. All optimized configurations include them.marchmabirv32iilp32rv32icilp32rv32imilp32rv32iailp32rv32imailp32rv32iacilp32rv32imacilp32rv32ic_zcb_zba_zbb_zbsilp32rv32imc_zcb_zba_zbb_zbsilp32rv32imac_zcb_zba_zbb_zbsilp32rv32imac_zcb_zba_zbb_zbs_zfinxilp32rv32imac_zcb_zba_zbb_zbs_zfinx_zdinxilp32List of RHX-100 configurations
-mtune=arc-v-rhx-100-series.-mcmodel=medlow.mac_zcb_zba_zbb_zbsset. All optimized configurations include them.Zcdand configurations withDextension containZcainstead ofC.marchmabirv32iilp32rv32icilp32rv32imilp32rv32iailp32rv32imailp32rv32iacilp32rv32imacilp32rv32imafcilp32frv32imafd_zcailp32drv32imac_zcb_zba_zbb_zbsilp32rv32imafc_zcb_zba_zbb_zbsilp32frv32imafd_zca_zcb_zba_zbb_zbsilp32dList of RPX-100 configurations
-mtune=arc-v-rhx-100-series.-mcmodel=medany.mac_zcb_zba_zbb_zbsset. All optimized configurations include them.marchmabirv64ilp64rv64iclp64rv64imlp64rv64imclp64rv64ialp64rv64imalp64rv64iaclp64rv64imaclp64rv64imafdclp64drv64imac_zcb_zba_zbb_zbslp64rv64imafdc_zcb_zba_zbb_zbslp64