Skip to content

fix(ci): escape carriage returns when checking log #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Jun 26, 2023

Motivation

CI seems to be flaky right now due the broadcast log test.

Solution

Just escape the \r carriage returns to not have this difference across OSs on this test.

@Evalir Evalir requested a review from mattsse June 26, 2023 18:42
@Evalir Evalir merged commit 7787e09 into master Jun 26, 2023
@Evalir Evalir deleted the evalir/fix-os-diff branch June 26, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants