-
Notifications
You must be signed in to change notification settings - Fork 1
Fix zarr parsing for multi-well setup: correct plate .zattrs #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We may need to define all the columns up to the max column that exists. The spec says we should and once we actually use the indices (columnIndex, rowIndex), that would start to matter. Thus, our columns & rows should probably not be parsed based on what is available, but set either by plate style (e.g. as a user-input) or parsed from max row/column. Columns for the above should look something like this:
(with optionally also column '12', because that physically exists on the plate. But shouldn't matter for our usecase) |
And regarding the wells dictionary, here is the full definition:
|
@jluethi two things here, The actual implementation is base on v0.3.0 https://ngff.openmicroscopy.org/0.3/ |
Sounds good. Let's fix the columns part first, then go into metadata afterwards :) |
So column uniqueness should be fixed with the latest commit (haven't tested this yet). But this metadata actually needs to follow another criteria: It needs to be in order. In the current parsing, rows & columns are ordered randomly, thus wells are displayed at random positions: If I manually order the columns correctly, then the wells are shown in the correct setup:
=> @mfranzon Can we introduce sorting to the rows & columns? Also, maybe some of the loading wrong version parts is due to the version of our OME metadata? We get this warning in the beginning: |
First attempt towards pelkmanslab parsl/slurm config - ref #34
Fixes needed for the .zattrs on the plate level:
First, wells are currently saved as this:
According to the spec, they should be saved like this:
Looking at this, it seems they do 0-based indexing for both columns. Thus, we will need to parse A => 0, B => 1 and so on for the rows, column numbers go 01 => 0, 03 => 2 and so on.
Should look like this at the end:
Second, similar to this (96b50aa) bugfix for the rows, we'll need the equivalent for columns. When I parsed a 23 well experiment, I get this list of columns in the plate .zattrs file. Thus, the columns show up multiple times
That should get us pretty close to the standard, we can then implement things like version, field_count or times later, if they become relevant.
The text was updated successfully, but these errors were encountered: