-
Notifications
You must be signed in to change notification settings - Fork 1
Parse additional yokogawa_to_zarr parameters to the command line interface #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Another optional argument should be the delete argument |
* Isolate pyramid creation function [ref #53], and test it within maximum_intensity_projection task; * Remove "factor" from coarsening_factor variables (BREAKING); * Remove dims argument from create_zarr_structure; * Put back delete_in argument in yokogawa_to_zarr [ref #49]; * Fix match between (X,Y) dimensions and (chunk_size_x,chunk_size_y), when rechunking during pyramid creation [ref #32]; * Update examples folder.
At the moment,
and where one can also add the The configuration for parsl/slurm is currently set globally at the fractal level, and it is written in
By now the key point is the distinction between global and workflow-specific options, but the current structure is still provisional. |
Yes, I think we should think about that structure a bit further. Each task may require some parameters, so it may not make sense when scaling this up to have a global parameter setting, rather either parameters passed to each task (e.g. as command line arguments) or a json file that is being generated by task. |
Also, global slurm specification is a good beginning, but we'll have to think about use-cases where individual tasks have very different needs (e.g. a task that needs a GPU, or high memory vs. low memory tasks, potentially even the flexibility that a task may require different amounts of memory depending on the dataset) |
After switching away from the apply file, some important parameters are hard-coded in the fractal_cmd.py file. We should parse them to the command line, as users may need to change them.
Core would be:
num_levels
&ext
could be optional arguments with the current defaults. Dims should be a required parameter, as it will be different for basically every experiment (unless we can parse the metadata file and get that info directly, see: https://github.com/fractal-analytics-platform/mwe_fractal/issues/46, but support for manually setting this parameter should be maintained in case there is no metadata file)Also, how do we handle slurm parameters like number of nodes, cores, memory etc?
The text was updated successfully, but these errors were encountered: