Skip to content

Illumination Correction task with overwrite_input=False is missing ROI tables #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jluethi opened this issue Apr 24, 2024 · 1 comment
Assignees

Comments

@jluethi
Copy link
Collaborator

jluethi commented Apr 24, 2024

We need to add copying tables over from the non-corrected image, otherwise the new image will miss the ROI tables.

My default would be to copy over all tables for now. We could be selective, but that gets complex when users add their own table types (e.g. condition tables) etc.
In most cases, users should not have feature tables when they run illumination correction. If they do, the correct behavior is not fully defined (one could argue either way)

@jluethi
Copy link
Collaborator Author

jluethi commented Apr 24, 2024

Closed by #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant