Skip to content

723 Fix illumination correction task not copying tables #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

jluethi
Copy link
Collaborator

@jluethi jluethi commented Apr 24, 2024

Illumination correction task now correctly copies tables from the original image

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_tasks_core/tasks
  _zarr_utils.py
  illumination_correction.py
Project Total  

This report was generated by python-coverage-comment-action

@jluethi
Copy link
Collaborator Author

jluethi commented Apr 24, 2024

I've confirmed that this closes #723, both with tests & with running example 02 while setting overwrite_input to False.

@tcompa I will already merge now so we can proceed with the release & deployment on Monday. The main thing where a review would be great is the new _copy_tables_from_zarr_url function. I already opened an issue here so we can review this further: #725

@jluethi jluethi marked this pull request as ready for review April 24, 2024 15:41
@jluethi jluethi merged commit 1d1e965 into main Apr 24, 2024
18 checks passed
@jluethi jluethi deleted the 723_fix_illumination_correction_table_handling branch April 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant