Skip to content

Relabeling in napari workflows #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 4, 2022
Merged

Relabeling in napari workflows #167

merged 24 commits into from
Nov 4, 2022

Conversation

mfranzon
Copy link
Collaborator

@mfranzon mfranzon commented Oct 31, 2022

Close #138
Ref #172
Close #180

@mfranzon mfranzon requested a review from tcompa October 31, 2022 16:37
@jluethi
Copy link
Collaborator

jluethi commented Nov 1, 2022

I had a brief look at the 314 implementation. This assumes labels will always be ordered and the last entry will have the highest value. Can we make this assumption? I think it holds up most of the time for our examples. But we don't do any sorting, so there may be napari workflows a user can run that break this assumption.
Can we switch to a max() based increase of the label values?

Also, I'm wondering for this approach: We adapt the label values in the table here independently of how we'd adjust the ones in the images. It is of utmost importance that the matching remains 100% correct, i.e. we can't have any cases where after relabeling, image 2 has label 731 but the label 731 entry in the dataframe is from a measurement on image 3. How are we ensuring this does not happen?

@tcompa tcompa changed the title ref #138, implementation of relabeling, two possible ways, line 362 a… Relabeling in napari workflows Nov 4, 2022
@tcompa tcompa merged commit 509fcb5 into main Nov 4, 2022
@tcompa tcompa deleted the 138_relabeling branch November 4, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[napari-workflows] Isolate napari_workflow_wrapper tests from test_workflows [napari-worfklows] Relabeling
3 participants