Skip to content

Make Channel.window attribute optional in lib_ngff.py #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2023
Merged

Make Channel.window attribute optional in lib_ngff.py #548

merged 4 commits into from
Oct 4, 2023

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Oct 3, 2023 •
edited
Loading

close #547

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

@tcompa tcompa linked an issue Oct 3, 2023 that may be closed by this pull request
Omero channels window parameters became required unintentionally with 0.12.0 changes #547
Closed
@tcompa tcompa marked this pull request as ready for review October 3, 2023 07:22
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Coverage report

The coverage rate went from 90.2% to 90.2% ⬆️
The branch rate is 83%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_tasks_core/lib_ngff.py

100% of new lines are covered (94.08% of the complete file).

@tcompa tcompa requested a review from jluethi October 3, 2023 07:25
@tcompa tcompa mentioned this pull request Oct 3, 2023
Closed
jluethi
jluethi approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@jluethi jluethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Given that the whole omero metadata is supposed to be transitional, the spec isn't very clear on which parts must be there. And at least the napari viewer seems to handle it fine when no window is provided.

@tcompa tcompa merged commit 0efcf33 into main Oct 4, 2023
@tcompa tcompa deleted the 547-omero-channels-window-parameters-became-required-unintentionally-with-0120-changes branch October 4, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluethi jluethi jluethi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Omero channels window parameters became required unintentionally with 0.12.0 changes
2 participants
@tcompa @jluethi