Skip to content

Handle GroupNotFoundError in load_NgffImageMeta and load_NgffWellMeta #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Dec 5, 2023

close #621

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Copy link

github-actions bot commented Dec 5, 2023

Coverage report

The coverage rate went from 90.74% to 90.78% ⬆️
The branch rate is 84%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_tasks_core/lib_ngff.py

100% of new lines are covered (94.97% of the complete file).

Copy link
Collaborator

@jluethi jluethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this with minor rewording of the error message

@tcompa tcompa merged commit d91e9f4 into main Dec 11, 2023
@tcompa tcompa deleted the 621-load_ngffimagemeta-should-have-a-more-descriptive-error-when-an-image-doesnt-exist branch December 11, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_NgffImageMeta should have a more descriptive error when an image doesn't exist
2 participants