Skip to content

Avoid file references being written to bundles #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sv2dev opened this issue May 15, 2016 · 3 comments
Closed

Avoid file references being written to bundles #127

sv2dev opened this issue May 15, 2016 · 3 comments

Comments

@sv2dev
Copy link

sv2dev commented May 15, 2016

As pointed out in this issue comment there are some file references written to the bundles.

This behavior leads to problems using hot module replacement when used together with bundling.
sv2dev added a commit to flaviait/ng2-jspm-template that referenced this issue May 15, 2016
@sv2dev
Disable typeCheck for browser compilation
951f8fb 
We have to disable this because of
frankwallis/plugin-typescript#127
(We are using bundling in combination with hmr).
@frankwallis
Copy link
Owner

I'm hoping this will automatically be resolved when rollup support becomes available with TypeScript 2.0.
See #97

@laurentgoudet
Copy link

Unfortunately this is still an issue when the loader is used in production, as rollup only works for static builds. For now disabling typeChecks works around the issue, but it means that the TypeScript build as to be enforced by another way, e.g. a duplicate compilation pass.

@frankwallis
Copy link
Owner

type-checking is no longer supported in 7.0.0 and so I believe this will no longer be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sv2dev @laurentgoudet @frankwallis