Skip to content

Document intended usage for disabled Text #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duranmla opened this issue Jun 3, 2021 · 8 comments · Fixed by #170
Closed

Document intended usage for disabled Text #103

duranmla opened this issue Jun 3, 2021 · 8 comments · Fixed by #170
Assignees
Labels
documentation Improvements or additions to documentation released on @next released

Comments

@duranmla
Copy link
Contributor

duranmla commented Jun 3, 2021

Relates to #96

@duranmla duranmla added the documentation Improvements or additions to documentation label Jun 3, 2021
@rafael-sepeda
Copy link

In order to make more clear the purpose of the disabled text color in addition to providing a descrition for this color slot I propose also to:

  1. Rename weak to secondary. Word weak might be confused with disabled. Also secondary is more-or-less a standard name for this color slot.
  2. Change $color.text.disabled to $colors.brand.authenticBlue.200. Currently it is set to 350 and it has not enough contrast/difference with secondary (weak) . We use actually already use $colors.brand.authenticBlue.200 in disabled states in inputs, and buttons, checkbox and other. $colors.brand.authenticBlue.350 it used for for disable-inverted states in some form controls, text input placeholder and default Tab in the tab bar. And this clashes with the idea of disabled.
  3. Give name to the default text color - primary.
  4. Describe all the color text slots.

So to be more systematic we can define the purpose of the text color slot this way:

  • primary - color for most interface text whether body or headlines.
  • secondary - for supplemental information with diminished contrast (often, the “gray text”). Like form microcopy, captions, helper text and other medium emphasised text elements.
  • disabled - for text in blocks, form elements or other components that are not available to a user at the moment (due to either permissions, dependencies, or pre-requisites) and need to feature “incidental” states.

Regarding color contrast WCAG 2.0 clearly defines that "incidental" text that is not required to meet the contrast requirements.

@rafael-sepeda
Copy link

As and alternative instead of primary we can use default.

@rafael-sepeda
Copy link

This issue/discussion is also, probably, related to #97

@rafael-sepeda
Copy link

@agonzalezUX any comments from your side?

@rafael-sepeda
Copy link

@duranmla , @nlopin so then, what will be the next steps for this topic?

@rafael-sepeda rafael-sepeda added the conversation needed Issues that may need to go to a broader conversation label Jul 1, 2021
@duranmla
Copy link
Contributor Author

We need to execute, sorry for the delays.

@duranmla duranmla removed the conversation needed Issues that may need to go to a broader conversation label Jul 15, 2021
@nlopin nlopin assigned nlopin and unassigned rafael-sepeda Aug 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released on @next released
Development

Successfully merging a pull request may close this issue.

3 participants