-
Notifications
You must be signed in to change notification settings - Fork 24
Adds disabled checkbox text color #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds disabled checkbox text color #97
Conversation
Now I understand #96 nonetheless, I am not sure if we should achieve this by using the parent (although I understand it is not a "recommended" practice on styled-components). Kinda, Checkbox = css`
${Text} {
// disable styles
}
` But at the same time Why not allow disabled prop on |
In my opinion, since we're adding a disabled property to |
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @lloydaf for code collaboration after this pull request |
I've put up a pull request to add @lloydaf! 🎉 |
What:
This PR fixes the color of the text of the
disabled
state for theChecbox
component.
Why:
This is in regard to SUP-11111
How:
disabled
property to theText
component insideCheckbox
Media: