Skip to content

Expand PhoneInput API #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 26, 2022
Merged

Expand PhoneInput API #261

merged 6 commits into from
Jul 26, 2022

Conversation

nlopin
Copy link
Contributor

@nlopin nlopin commented Jul 14, 2022

What

Allows to attach portals and exposes implementation level APIs
​
Why:

Closes #256 #259

​
How:

  • adds listPortalTarget prop to be able to attach the prefixes popup to another HTML element
  • adds inputProps and selectListProps props and passes them to the corresponding components. Those props has less priority than higher level props of the PhoneInput (e.g. <PhoneInput id='hello' inputProps={{id: 'input'}} /> will use hello as the id)
  • updated the documentation
    ​
    Checklist:
  • Ready to be merged

@nlopin nlopin added the enhancement New feature or request label Jul 14, 2022
@nlopin nlopin changed the title Phoneinput broader api Expand PhoneInput API Jul 14, 2022
@nlopin nlopin changed the title Expand PhoneInput API Expand PhoneInput API Jul 14, 2022
@nlopin nlopin linked an issue Jul 14, 2022 that may be closed by this pull request
Expose event props onFocus and onOpen from the PhoneInput #259
Closed
@nlopin nlopin removed the request for review from rafael-sepeda July 14, 2022 16:23
martimalek
martimalek approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@martimalek martimalek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@nlopin nlopin merged commit 07f4c40 into main Jul 26, 2022
@nlopin nlopin deleted the phoneinput-broader-api branch July 26, 2022 10:22
lloydaf added a commit that referenced this pull request Aug 2, 2022
@lloydaf @martimalek
@semantic-release-bot @JanHamara
Merge main (#270)
6c640cb 
* docs: remove the experimental label for table (#255)

* fix: display semantic colors in table and allow to filter them (#258)

* fix: display semantic colors in table and allow to filter them

* refactor: improve performance of SemanticColorsTable

* fix: trim table filter input

Co-authored-by: Martí Malek <[email protected]>

* chore(release): 1.25.2 [skip ci]

### [1.25.2](v1.25.1...v1.25.2) (2022-07-11)

### Bug Fixes

* display semantic colors in table and allow to filter them ([#258](#258)) ([2e83e76](2e83e76))

* update codeowners

removes Rafa from the list 😢

* style(popover): expose padding prop for Popover component (#262)

Co-authored-by: Ján Hamara <[email protected]>

* fix: expose padding prop and adjust z-index for Popover component (#263)

* style(popover): expose padding prop for Popover component

* fix: update zIndex on Popover content container

Co-authored-by: Ján Hamara <[email protected]>

* chore(release): 1.25.3 [skip ci]

### [1.25.3](v1.25.2...v1.25.3) (2022-07-21)

### Bug Fixes

* expose padding prop and adjust z-index for Popover component ([#263](#263)) ([da0e80b](da0e80b))

* Expand PhoneInput API (#261)

Exposes properties to reach lower-level components of the `PhoneInput`

Co-authored-by: martimalek <[email protected]>

* 1.26.0

* 1.26.1

Co-authored-by: martimalek <[email protected]>
Co-authored-by: Martí Malek <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: Jan Hamara <[email protected]>
Co-authored-by: Ján Hamara <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
lloydaf added a commit that referenced this pull request Aug 4, 2022
@lloydaf @martimalek
@semantic-release-bot @JanHamara
merging main with the prop branch (#277)
0a6fa49 
* docs: remove the experimental label for table (#255)

* fix: display semantic colors in table and allow to filter them (#258)

* fix: display semantic colors in table and allow to filter them

* refactor: improve performance of SemanticColorsTable

* fix: trim table filter input

Co-authored-by: Martí Malek <[email protected]>

* chore(release): 1.25.2 [skip ci]

### [1.25.2](v1.25.1...v1.25.2) (2022-07-11)

### Bug Fixes

* display semantic colors in table and allow to filter them ([#258](#258)) ([2e83e76](2e83e76))

* update codeowners

removes Rafa from the list 😢

* style(popover): expose padding prop for Popover component (#262)

Co-authored-by: Ján Hamara <[email protected]>

* fix: expose padding prop and adjust z-index for Popover component (#263)

* style(popover): expose padding prop for Popover component

* fix: update zIndex on Popover content container

Co-authored-by: Ján Hamara <[email protected]>

* chore(release): 1.25.3 [skip ci]

### [1.25.3](v1.25.2...v1.25.3) (2022-07-21)

### Bug Fixes

* expose padding prop and adjust z-index for Popover component ([#263](#263)) ([da0e80b](da0e80b))

* Expand PhoneInput API (#261)

Exposes properties to reach lower-level components of the `PhoneInput`

Co-authored-by: martimalek <[email protected]>

* 1.26.0

* 1.26.1

Co-authored-by: martimalek <[email protected]>
Co-authored-by: Martí Malek <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: Jan Hamara <[email protected]>
Co-authored-by: Ján Hamara <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
lloydaf added a commit that referenced this pull request Aug 4, 2022
@arturmiglio @lloydaf
@martimalek @semantic-release-bot @JanHamara
docs(props-table): add props table to Table docs (#275)
bd9310b 
* docs: remove the experimental label for table (#255)

* fix: display semantic colors in table and allow to filter them (#258)

* fix: display semantic colors in table and allow to filter them

* refactor: improve performance of SemanticColorsTable

* fix: trim table filter input

Co-authored-by: Martí Malek <[email protected]>

* chore(release): 1.25.2 [skip ci]

### [1.25.2](v1.25.1...v1.25.2) (2022-07-11)

### Bug Fixes

* display semantic colors in table and allow to filter them ([#258](#258)) ([2e83e76](2e83e76))

* update codeowners

removes Rafa from the list 😢

* style(popover): expose padding prop for Popover component (#262)

Co-authored-by: Ján Hamara <[email protected]>

* fix: expose padding prop and adjust z-index for Popover component (#263)

* style(popover): expose padding prop for Popover component

* fix: update zIndex on Popover content container

Co-authored-by: Ján Hamara <[email protected]>

* chore(release): 1.25.3 [skip ci]

### [1.25.3](v1.25.2...v1.25.3) (2022-07-21)

### Bug Fixes

* expose padding prop and adjust z-index for Popover component ([#263](#263)) ([da0e80b](da0e80b))

* Expand PhoneInput API (#261)

Exposes properties to reach lower-level components of the `PhoneInput`

Co-authored-by: martimalek <[email protected]>

* 1.26.0

* 1.26.1

* docs(props-table): add props table to Table docs

* chore: update package-lock.json

Co-authored-by: Lloyd Francis <[email protected]>
Co-authored-by: martimalek <[email protected]>
Co-authored-by: Martí Malek <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: Jan Hamara <[email protected]>
Co-authored-by: Ján Hamara <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
lloydaf added a commit that referenced this pull request Aug 4, 2022
@lloydaf @martimalek
@semantic-release-bot @JanHamara @dani-walnut @arturmiglio
Issue 10 add prop documentation (#276)
b0e0862 
* Merge main (#270)

* docs: remove the experimental label for table (#255)

* fix: display semantic colors in table and allow to filter them (#258)

* fix: display semantic colors in table and allow to filter them

* refactor: improve performance of SemanticColorsTable

* fix: trim table filter input

Co-authored-by: Martí Malek <[email protected]>

* chore(release): 1.25.2 [skip ci]

### [1.25.2](v1.25.1...v1.25.2) (2022-07-11)

### Bug Fixes

* display semantic colors in table and allow to filter them ([#258](#258)) ([2e83e76](2e83e76))

* update codeowners

removes Rafa from the list 😢

* style(popover): expose padding prop for Popover component (#262)

Co-authored-by: Ján Hamara <[email protected]>

* fix: expose padding prop and adjust z-index for Popover component (#263)

* style(popover): expose padding prop for Popover component

* fix: update zIndex on Popover content container

Co-authored-by: Ján Hamara <[email protected]>

* chore(release): 1.25.3 [skip ci]

### [1.25.3](v1.25.2...v1.25.3) (2022-07-21)

### Bug Fixes

* expose padding prop and adjust z-index for Popover component ([#263](#263)) ([da0e80b](da0e80b))

* Expand PhoneInput API (#261)

Exposes properties to reach lower-level components of the `PhoneInput`

Co-authored-by: martimalek <[email protected]>

* 1.26.0

* 1.26.1

Co-authored-by: martimalek <[email protected]>
Co-authored-by: Martí Malek <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: Jan Hamara <[email protected]>
Co-authored-by: Ján Hamara <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>

* docs(headline): update props table

* improvement: adding props table for filepicker

* docs(pagination): update props table

* docs(select): update props table

* Issue 10 add prop documentation (#271)

* docs(tabbar): update props table

* improvement: props table for datepicker

* improvement: adding props table to Tooltip

* improvement: adding PropsTable to Toggle

* improvement: adding propstable for Textarea

* merging main with the prop branch (#277)

* docs: remove the experimental label for table (#255)

* fix: display semantic colors in table and allow to filter them (#258)

* fix: display semantic colors in table and allow to filter them

* refactor: improve performance of SemanticColorsTable

* fix: trim table filter input

Co-authored-by: Martí Malek <[email protected]>

* chore(release): 1.25.2 [skip ci]

### [1.25.2](v1.25.1...v1.25.2) (2022-07-11)

### Bug Fixes

* display semantic colors in table and allow to filter them ([#258](#258)) ([2e83e76](2e83e76))

* update codeowners

removes Rafa from the list 😢

* style(popover): expose padding prop for Popover component (#262)

Co-authored-by: Ján Hamara <[email protected]>

* fix: expose padding prop and adjust z-index for Popover component (#263)

* style(popover): expose padding prop for Popover component

* fix: update zIndex on Popover content container

Co-authored-by: Ján Hamara <[email protected]>

* chore(release): 1.25.3 [skip ci]

### [1.25.3](v1.25.2...v1.25.3) (2022-07-21)

### Bug Fixes

* expose padding prop and adjust z-index for Popover component ([#263](#263)) ([da0e80b](da0e80b))

* Expand PhoneInput API (#261)

Exposes properties to reach lower-level components of the `PhoneInput`

Co-authored-by: martimalek <[email protected]>

* 1.26.0

* 1.26.1

Co-authored-by: martimalek <[email protected]>
Co-authored-by: Martí Malek <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: Jan Hamara <[email protected]>
Co-authored-by: Ján Hamara <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>

* docs(props-table): add props table to Table docs (#275)

* docs: remove the experimental label for table (#255)

* fix: display semantic colors in table and allow to filter them (#258)

* fix: display semantic colors in table and allow to filter them

* refactor: improve performance of SemanticColorsTable

* fix: trim table filter input

Co-authored-by: Martí Malek <[email protected]>

* chore(release): 1.25.2 [skip ci]

### [1.25.2](v1.25.1...v1.25.2) (2022-07-11)

### Bug Fixes

* display semantic colors in table and allow to filter them ([#258](#258)) ([2e83e76](2e83e76))

* update codeowners

removes Rafa from the list 😢

* style(popover): expose padding prop for Popover component (#262)

Co-authored-by: Ján Hamara <[email protected]>

* fix: expose padding prop and adjust z-index for Popover component (#263)

* style(popover): expose padding prop for Popover component

* fix: update zIndex on Popover content container

Co-authored-by: Ján Hamara <[email protected]>

* chore(release): 1.25.3 [skip ci]

### [1.25.3](v1.25.2...v1.25.3) (2022-07-21)

### Bug Fixes

* expose padding prop and adjust z-index for Popover component ([#263](#263)) ([da0e80b](da0e80b))

* Expand PhoneInput API (#261)

Exposes properties to reach lower-level components of the `PhoneInput`

Co-authored-by: martimalek <[email protected]>

* 1.26.0

* 1.26.1

* docs(props-table): add props table to Table docs

* chore: update package-lock.json

Co-authored-by: Lloyd Francis <[email protected]>
Co-authored-by: martimalek <[email protected]>
Co-authored-by: Martí Malek <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: Jan Hamara <[email protected]>
Co-authored-by: Ján Hamara <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>

* docs(table): remove unused tables

* docs(datepicker): add links to styled-system props

* docs(textarea): add semicolons

* docs(toggle): add classname and styled-system props to the documentation

* docs(select): change import order

* docs(filepicker): add styled-system props link

* docs(headline): add styled-system props link

* docs(helpertext): add styled-system props link

* docs(link): add styled-system props link

* docs(tag): add styled-system props link

Co-authored-by: martimalek <[email protected]>
Co-authored-by: Martí Malek <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: Jan Hamara <[email protected]>
Co-authored-by: Ján Hamara <[email protected]>
Co-authored-by: Nikolai Lopin <[email protected]>
Co-authored-by: dani-walnut <[email protected]>
Co-authored-by: Artur Miglio <[email protected]>
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@div-Leo div-Leo div-Leo approved these changes

@martimalek martimalek martimalek approved these changes

@jonotrujillo jonotrujillo Awaiting requested review from jonotrujillo jonotrujillo is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request released on @next
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose event props onFocus and onOpen from the PhoneInput PhoneInput view cut
3 participants
@nlopin @div-Leo @martimalek