Skip to content

Commit eb02b80

Browse files
authored
Remove (now invalid) default URL for dispatch API (#166)
2 parents c4a0f60 + d0bdb0d commit eb02b80

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

RELEASE_NOTES.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
# Frequenz Dispatch Client Library Release Notes
22

3-
## Features
4-
5-
* The dispatch client now supports the official dispatch domain.
63

74
## Bug Fixes
85

9-
* Fix that a user might see invalid values for dispatches without `end_time`. It was not correctly handling the `None` value when converted from protobuf to pythons `Dispatch` class.
6+
* Fix cli client trying to use a invalid default URL when none is given.
107

118
## Upgrading
129

13-
* Renamed `Client` class to `DispatchApiClient` for clarity.
10+
* You now must always provide the URL to the dispatch client.

src/frequenz/client/dispatch/__main__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
from .recurrence import EndCriteria, Frequency, RecurrenceRule, Weekday
3030
from .types import Dispatch, DispatchEvent
3131

32-
DEFAULT_DISPATCH_API_URL = "grpc://dispatch.url.goes.here.example.com"
33-
3432

3533
def format_datetime(dt: datetime | None) -> str:
3634
"""Format datetime object to a readable string, or return 'N/A' if None."""
@@ -165,11 +163,9 @@ def format_line(key: str, value: str, color: str = "cyan") -> str:
165163
@click.group(invoke_without_command=True)
166164
@click.option(
167165
"--url",
168-
default=DEFAULT_DISPATCH_API_URL,
169166
help="Dispatch API Url",
170167
envvar="DISPATCH_API_URL",
171168
show_envvar=True,
172-
show_default=True,
173169
)
174170
@click.option(
175171
"--key",

0 commit comments

Comments
 (0)