Skip to content

Remove (now invalid) default URL for dispatch API #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Remove (now invalid) default URL for dispatch API #166

merged 1 commit into from
May 14, 2025

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented May 14, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 14:57
@Marenz Marenz requested review from a team as code owners May 14, 2025 14:57
Copilot
Copilot AI reviewed May 14, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the now invalid default URL used for the Dispatch API. The changes include:

  • Removing the DEFAULT_DISPATCH_API_URL constant.
  • Removing the default value and show_default flag from the click option for "--url".

@github-actions github-actions bot added part:cli Affects the command-line interface part:dispatcher labels May 14, 2025
@Marenz Marenz requested a review from llucax May 14, 2025 14:57
@github-actions github-actions bot added the part:docs Affects the documentation label May 14, 2025
Marenz
Marenz commented May 14, 2025
View reviewed changes
Copy link
Contributor Author

@Marenz Marenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marenz Marenz merged commit eb02b80 into frequenz-floss:v0.x.x May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@stefan-brus-frequenz stefan-brus-frequenz Awaiting requested review from stefan-brus-frequenz stefan-brus-frequenz is a code owner automatically assigned from frequenz-floss/api-dispatch-team

@ela-kotulska-frequenz ela-kotulska-frequenz Awaiting requested review from ela-kotulska-frequenz ela-kotulska-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

@llucax llucax Awaiting requested review from llucax

Assignees
No one assigned
Labels
part:cli Affects the command-line interface part:dispatcher part:docs Affects the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Marenz